Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2370033003: [inspector] test for fixed empty stack processing in console.count (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] test for fixed empty stack processing in console.count BUG=chromium:644629 R=dgozman@chromium.org Committed: https://crrev.com/759581ea933acd5b72d3d2c61048be9377cf6c19 Cr-Commit-Position: refs/heads/master@{#39938}

Patch Set 1 #

Patch Set 2 : a #

Total comments: 2

Patch Set 3 : addressed comments #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A test/inspector/debugger/async-console-count-doesnt-crash.js View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A test/inspector/debugger/async-console-count-doesnt-crash-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/inspector/protocol-test.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
kozy
Dmitry, please take a look. It's a test for https://codereview.chromium.org/2372093002/ I'll be able to land ...
4 years, 2 months ago (2016-09-27 02:12:34 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2370033003/diff/20001/test/inspector-protocol/protocol-test.js File test/inspector-protocol/protocol-test.js (right): https://codereview.chromium.org/2370033003/diff/20001/test/inspector-protocol/protocol-test.js#newcode142 test/inspector-protocol/protocol-test.js:142: awaitPromise: true }, InspectorTest.completeTest) missing semicolon
4 years, 2 months ago (2016-09-27 16:33:19 UTC) #3
kozy
All done. https://codereview.chromium.org/2370033003/diff/20001/test/inspector-protocol/protocol-test.js File test/inspector-protocol/protocol-test.js (right): https://codereview.chromium.org/2370033003/diff/20001/test/inspector-protocol/protocol-test.js#newcode142 test/inspector-protocol/protocol-test.js:142: awaitPromise: true }, InspectorTest.completeTest) On 2016/09/27 16:33:19, ...
4 years, 2 months ago (2016-09-27 20:22:10 UTC) #4
kozy
Alexey, please take a look!
4 years, 2 months ago (2016-09-30 02:12:54 UTC) #6
alph
lgtm
4 years, 2 months ago (2016-10-03 20:24:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370033003/60001
4 years, 2 months ago (2016-10-03 20:42:42 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-03 21:10:45 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:11:00 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/759581ea933acd5b72d3d2c61048be9377cf6c19
Cr-Commit-Position: refs/heads/master@{#39938}

Powered by Google App Engine
This is Rietveld 408576698