Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2369413002: Fixes bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes bug in WmWindowAura::OnWindowVisibilityChanged() The code was assuming window was this->window_, which is not necessarily the case. BUG=650755 TEST=none R=oshima@chromium.org Committed: https://crrev.com/598ab1479d421bc56bec0659bb6aacfaed6d6959 Cr-Commit-Position: refs/heads/master@{#421298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ash/aura/wm_window_aura.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/window_observer.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
I will right a test shortly.
4 years, 2 months ago (2016-09-27 18:26:25 UTC) #1
oshima
Thank you for prompt fix! Confirmed that this fixes the issue. lgtm
4 years, 2 months ago (2016-09-27 18:41:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369413002/1
4 years, 2 months ago (2016-09-27 18:46:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:37:16 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:38:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/598ab1479d421bc56bec0659bb6aacfaed6d6959
Cr-Commit-Position: refs/heads/master@{#421298}

Powered by Google App Engine
This is Rietveld 408576698