Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: ash/aura/wm_window_aura.cc

Issue 2369413002: Fixes bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/aura/window_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/aura/wm_window_aura.h" 5 #include "ash/aura/wm_window_aura.h"
6 6
7 #include "ash/aura/aura_layout_manager_adapter.h" 7 #include "ash/aura/aura_layout_manager_adapter.h"
8 #include "ash/aura/wm_root_window_controller_aura.h" 8 #include "ash/aura/wm_root_window_controller_aura.h"
9 #include "ash/aura/wm_shell_aura.h" 9 #include "ash/aura/wm_shell_aura.h"
10 #include "ash/common/ash_constants.h" 10 #include "ash/common/ash_constants.h"
(...skipping 839 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 void WmWindowAura::OnWindowDestroying(aura::Window* window) { 850 void WmWindowAura::OnWindowDestroying(aura::Window* window) {
851 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this)); 851 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this));
852 } 852 }
853 853
854 void WmWindowAura::OnWindowDestroyed(aura::Window* window) { 854 void WmWindowAura::OnWindowDestroyed(aura::Window* window) {
855 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this)); 855 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this));
856 } 856 }
857 857
858 void WmWindowAura::OnWindowVisibilityChanging(aura::Window* window, 858 void WmWindowAura::OnWindowVisibilityChanging(aura::Window* window,
859 bool visible) { 859 bool visible) {
860 DCHECK_EQ(window, window_);
860 FOR_EACH_OBSERVER(WmWindowObserver, observers_, 861 FOR_EACH_OBSERVER(WmWindowObserver, observers_,
861 OnWindowVisibilityChanging(this, visible)); 862 OnWindowVisibilityChanging(this, visible));
862 } 863 }
863 864
864 void WmWindowAura::OnWindowVisibilityChanged(aura::Window* window, 865 void WmWindowAura::OnWindowVisibilityChanged(aura::Window* window,
865 bool visible) { 866 bool visible) {
866 FOR_EACH_OBSERVER(WmWindowObserver, observers_, 867 FOR_EACH_OBSERVER(WmWindowObserver, observers_,
867 OnWindowVisibilityChanged(this, visible)); 868 OnWindowVisibilityChanged(Get(window), visible));
868 } 869 }
869 870
870 void WmWindowAura::OnWindowTitleChanged(aura::Window* window) { 871 void WmWindowAura::OnWindowTitleChanged(aura::Window* window) {
871 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowTitleChanged(this)); 872 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowTitleChanged(this));
872 } 873 }
873 874
874 void WmWindowAura::OnTransientChildAdded(aura::Window* window, 875 void WmWindowAura::OnTransientChildAdded(aura::Window* window,
875 aura::Window* transient) { 876 aura::Window* transient) {
876 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_, 877 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
877 OnTransientChildAdded(this, Get(transient))); 878 OnTransientChildAdded(this, Get(transient)));
878 } 879 }
879 880
880 void WmWindowAura::OnTransientChildRemoved(aura::Window* window, 881 void WmWindowAura::OnTransientChildRemoved(aura::Window* window,
881 aura::Window* transient) { 882 aura::Window* transient) {
882 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_, 883 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
883 OnTransientChildRemoved(this, Get(transient))); 884 OnTransientChildRemoved(this, Get(transient)));
884 } 885 }
885 886
886 } // namespace ash 887 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ui/aura/window_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698