Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: ash/aura/wm_window_aura.cc

Issue 2369413002: Fixes bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/aura/window_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/aura/wm_window_aura.cc
diff --git a/ash/aura/wm_window_aura.cc b/ash/aura/wm_window_aura.cc
index 831751f6d9d2f585bdbdcf352c558824390b0c71..9715a7c339eba8b46c7859dccd40cfb05cffc405 100644
--- a/ash/aura/wm_window_aura.cc
+++ b/ash/aura/wm_window_aura.cc
@@ -857,6 +857,7 @@ void WmWindowAura::OnWindowDestroyed(aura::Window* window) {
void WmWindowAura::OnWindowVisibilityChanging(aura::Window* window,
bool visible) {
+ DCHECK_EQ(window, window_);
FOR_EACH_OBSERVER(WmWindowObserver, observers_,
OnWindowVisibilityChanging(this, visible));
}
@@ -864,7 +865,7 @@ void WmWindowAura::OnWindowVisibilityChanging(aura::Window* window,
void WmWindowAura::OnWindowVisibilityChanged(aura::Window* window,
bool visible) {
FOR_EACH_OBSERVER(WmWindowObserver, observers_,
- OnWindowVisibilityChanged(this, visible));
+ OnWindowVisibilityChanged(Get(window), visible));
}
void WmWindowAura::OnWindowTitleChanged(aura::Window* window) {
« no previous file with comments | « no previous file | ui/aura/window_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698