Fix stream errors that occur after a stream starts not propagating.

Fix stream errors that occur after a stream starts not propagating.

Currently a stream was treated as having no errors even if an error occurs after reading starts. This change plumbs the error through.

This fixes the following tests with PlzNavigate:
ChromeURLDataManagerTest.LargeResourceScale
ChromeURLDataManagerTest.UnknownResource

BUG=426162, 508957, 504347
Committed: https://crrev.com/e87eeddc2e3bdba960c0803221864a1f8037b33b
Cr-Commit-Position: refs/heads/master@{#421237}

[jam, 2016-09-26 06:57:07]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 06:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 07:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 07:14:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-09-26 15:01:51]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 15:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-26 15:02:56]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-09-26 15:04:50]

jam@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-27 10:24:56]

lgtm

https://codereview.chromium.org/2368913002/diff/20001/content/browser/fileapi...
File content/browser/fileapi/fileapi_message_filter.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/fileapi...
content/browser/fileapi/fileapi_message_filter.cc:568: stream->Finalize(0);
net::OK

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
File content/browser/streams/stream_unittest.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:64: completed_ = true;
save GetStatus() here and export as status()?

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:200: EXPECT_TRUE(reader.completed());
check status() here

and could you please add a test case where an instantiated Stream is immediately
Finalize()-ed with some non-zero value and check whether or not status() is set
to the value?

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:239: stream->Finalize(0);
check status() here

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
File content/browser/streams/stream_url_request_job.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_url_request_job.cc:33: error_code_(0),
how about net::OK so that it's clear that it's intended to hold a net error?

[jam, 2016-09-27 15:41:08]

https://codereview.chromium.org/2368913002/diff/20001/content/browser/fileapi...
File content/browser/fileapi/fileapi_message_filter.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/fileapi...
content/browser/fileapi/fileapi_message_filter.cc:568: stream->Finalize(0);
On 2016/09/27 10:24:56, tyoshino wrote:
> net::OK

Done.

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
File content/browser/streams/stream_unittest.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:64: completed_ = true;
On 2016/09/27 10:24:56, tyoshino wrote:
> save GetStatus() here and export as status()?

Done.

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:200: EXPECT_TRUE(reader.completed());
On 2016/09/27 10:24:56, tyoshino wrote:
> check status() here
> 
> and could you please add a test case where an instantiated Stream is
immediately
> Finalize()-ed with some non-zero value and check whether or not status() is
set
> to the value?

Done.

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_unittest.cc:239: stream->Finalize(0);
On 2016/09/27 10:24:56, tyoshino wrote:
> check status() here

Done.

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
File content/browser/streams/stream_url_request_job.cc (right):

https://codereview.chromium.org/2368913002/diff/20001/content/browser/streams...
content/browser/streams/stream_url_request_job.cc:33: error_code_(0),
On 2016/09/27 10:24:56, tyoshino wrote:
> how about net::OK so that it's clear that it's intended to hold a net error?

Done.

[jam, 2016-09-27 15:41:36]

The CQ bit was checked by jam@chromium.org

[jam, 2016-09-27 15:41:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/2368913002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-09-27 15:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 17:00:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 17:03:14]

Description was changed from

==========
Fix stream errors that occur after a stream starts not propagating.

Currently a stream was treated as having no errors even if an error occurs after
reading starts. This change plumbs the error through.

This fixes the following tests with PlzNavigate:
ChromeURLDataManagerTest.LargeResourceScale
ChromeURLDataManagerTest.UnknownResource

BUG=426162,508957,504347
==========

to

==========
Fix stream errors that occur after a stream starts not propagating.

Currently a stream was treated as having no errors even if an error occurs after
reading starts. This change plumbs the error through.

This fixes the following tests with PlzNavigate:
ChromeURLDataManagerTest.LargeResourceScale
ChromeURLDataManagerTest.UnknownResource

BUG=426162,508957,504347

Committed: https://crrev.com/e87eeddc2e3bdba960c0803221864a1f8037b33b
Cr-Commit-Position: refs/heads/master@{#421237}
==========

[commit-bot: I haz the power, 2016-09-27 17:03:15]

Patchset 3 (id:??) landed as
https://crrev.com/e87eeddc2e3bdba960c0803221864a1f8037b33b
Cr-Commit-Position: refs/heads/master@{#421237}