Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2368913002: Fix stream errors that occur after a stream starts not propagating. (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/stream_writer.cc ('k') | content/browser/streams/stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 34bfff4c8a0da1b071a04862b7bbb790f51b4ca7..690154c23ea88576ed89108ba36da479309351b7 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -578,7 +578,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, StreamResponse) {
expected_response += kTestData;
stream->AddData(kTestData, sizeof(kTestData) - 1);
}
- stream->Finalize();
+ stream->Finalize(net::OK);
EXPECT_FALSE(HasWork());
base::RunLoop().RunUntilIdle();
@@ -628,7 +628,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, StreamResponse_DelayedRegistration) {
expected_response += kTestData;
stream->AddData(kTestData, sizeof(kTestData) - 1);
}
- stream->Finalize();
+ stream->Finalize(net::OK);
EXPECT_FALSE(HasWork());
base::RunLoop().RunUntilIdle();
@@ -670,7 +670,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, StreamResponse_QuickFinalize) {
expected_response += kTestData;
stream->AddData(kTestData, sizeof(kTestData) - 1);
}
- stream->Finalize();
+ stream->Finalize(net::OK);
SetUpWithHelper(new StreamResponder(stream_url));
version_->SetStatus(ServiceWorkerVersion::ACTIVATED);
@@ -729,7 +729,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, StreamResponse_Flush) {
base::RunLoop().RunUntilIdle();
EXPECT_EQ(expected_response, url_request_delegate_.response_data());
}
- stream->Finalize();
+ stream->Finalize(net::OK);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(request_->status().is_success());
EXPECT_EQ(200,
@@ -786,7 +786,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, StreamResponseAndCancel) {
expected_response += kTestData;
stream->AddData(kTestData, sizeof(kTestData) - 1);
}
- stream->Finalize();
+ stream->Finalize(net::OK);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(request_->status().is_success());
@@ -830,7 +830,7 @@ TEST_F(ServiceWorkerURLRequestJobTest,
ASSERT_FALSE(stream_context->registry()->GetStream(stream_url).get());
for (int i = 0; i < 1024; ++i)
stream->AddData(kTestData, sizeof(kTestData) - 1);
- stream->Finalize();
+ stream->Finalize(net::OK);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(request_->status().is_success());
« no previous file with comments | « content/browser/loader/stream_writer.cc ('k') | content/browser/streams/stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698