Fix stream errors that occur after a stream starts not propagating.

content/browser/streams/stream_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "content/browser/streams/stream.h"
 #include "content/browser/streams/stream_read_observer.h"
 #include "content/browser/streams/stream_register_observer.h"
 #include "content/browser/streams/stream_registry.h"
 #include "content/browser/streams/stream_write_observer.h"
+#include "net/base/net_errors.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 class StreamTest : public testing::Test {
  public:
   StreamTest() : producing_seed_key_(0) {}
 
   void SetUp() override { registry_.reset(new StreamRegistry()); }
 
@@ skipping 30 matching lines @@
       Stream::StreamState state =
           stream->ReadRawData(buffer.get(), kBufferSize, &bytes_read);
       switch (state) {
         case Stream::STREAM_HAS_DATA:
           // TODO(tyoshino): Move these expectations to the beginning of Read()
           // method once Stream::Finalize() is fixed.
           EXPECT_FALSE(completed_);
           break;
         case Stream::STREAM_COMPLETE:
           completed_ = true;
+          status_ = stream->GetStatus();
           return;
         case Stream::STREAM_EMPTY:
           EXPECT_FALSE(completed_);
           return;
         case Stream::STREAM_ABORTED:
           aborted_ = true;
           EXPECT_FALSE(completed_);
           return;
       }
       size_t old_capacity = buffer_->capacity();
       buffer_->SetCapacity(old_capacity + bytes_read);
       memcpy(buffer_->StartOfBuffer() + old_capacity,
              buffer->data(), bytes_read);
     }
   }
 
   void OnDataAvailable(Stream* stream) override { Read(stream); }
 
   scoped_refptr<net::GrowableIOBuffer> buffer() { return buffer_; }
 
   bool completed() const { return completed_; }
   bool aborted() const { return aborted_; }
+  int status() const { return status_; }
 
  private:
   scoped_refptr<net::GrowableIOBuffer> buffer_;
   bool completed_ = false;
   bool aborted_ = false;
+  int status_ = 0;
 };
 
 class TestStreamWriter : public StreamWriteObserver {
  public:
   TestStreamWriter() {}
   ~TestStreamWriter() override {}
 
   void Write(Stream* stream,
              scoped_refptr<net::IOBuffer> buffer,
              size_t buffer_size) {
@@ skipping 86 matching lines @@
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream(
       new Stream(registry_.get(), &writer, url));
   EXPECT_TRUE(stream->SetReadObserver(&reader));
 
   const int kBufferSize = 1000000;
   scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
   writer.Write(stream.get(), buffer, kBufferSize);
-  stream->Finalize();
+  stream->Finalize(net::OK);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(reader.completed());
+  EXPECT_EQ(net::OK, reader.status());
 
   ASSERT_EQ(reader.buffer()->capacity(), kBufferSize);
   for (int i = 0; i < kBufferSize; i++)
     EXPECT_EQ(buffer->data()[i], reader.buffer()->data()[i]);
 }
 
 TEST_F(StreamTest, Abort) {
   TestStreamReader reader;
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream(new Stream(registry_.get(), &writer, url));
   EXPECT_TRUE(stream->SetReadObserver(&reader));
 
   stream->Abort();
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(reader.completed());
   EXPECT_TRUE(reader.aborted());
 }
 
+TEST_F(StreamTest, Error) {
+  TestStreamReader reader;
+  TestStreamWriter writer;
+
+  GURL url("blob://stream");
+  scoped_refptr<Stream> stream(new Stream(registry_.get(), &writer, url));
+  EXPECT_TRUE(stream->SetReadObserver(&reader));
+
+  stream->Finalize(net::ERR_ACCESS_DENIED);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(reader.completed());
+  EXPECT_EQ(net::ERR_ACCESS_DENIED, reader.status());
+}
+
 // Test that even if a reader receives an empty buffer, once TransferData()
 // method is called on it with |source_complete| = true, following Read() calls
 // on it never returns STREAM_EMPTY. Together with StreamTest.Stream above, this
 // guarantees that Reader::Read() call returns only STREAM_HAS_DATA
 // or STREAM_COMPLETE in |data_available_callback_| call corresponding to
 // Writer::Close().
 TEST_F(StreamTest, ClosedReaderDoesNotReturnStreamEmpty) {
   TestStreamReader reader;
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream(
       new Stream(registry_.get(), &writer, url));
   EXPECT_TRUE(stream->SetReadObserver(&reader));
 
   const int kBufferSize = 0;
   scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
   stream->AddData(buffer, kBufferSize);
-  stream->Finalize();
+  stream->Finalize(net::OK);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(reader.completed());
   EXPECT_EQ(0, reader.buffer()->capacity());
+  EXPECT_EQ(net::OK, reader.status());
 }
 
 TEST_F(StreamTest, GetStream) {
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream1(
       new Stream(registry_.get(), &writer, url));
 
   scoped_refptr<Stream> stream2 = registry_->GetStream(url);
@@ skipping 137 matching lines @@
 TEST_F(StreamTest, AbortPendingStream) {
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   registry_->AbortPendingStream(url);
   scoped_refptr<Stream> stream1(new Stream(registry_.get(), &writer, url));
   ASSERT_EQ(nullptr, registry_->GetStream(url).get());
 }
 
 }  // namespace content