Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 23684058: Unify handling of position info in AST, part 3 (Closed)

Created:
7 years, 3 months ago by rossberg
Modified:
7 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Unify handling of position info in AST, part 3 * Turn CaseClause into a proper AstNode R=yangguo@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=17187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -13 lines) Patch
M src/ast.h View 5 chunks +19 lines, -10 lines 0 comments Download
M src/ast.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/rewriter.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 3 months ago (2013-09-12 14:55:09 UTC) #1
Yang
On 2013/09/12 14:55:09, rossberg wrote: lgtm.
7 years, 3 months ago (2013-09-24 16:19:09 UTC) #2
rossberg
7 years, 2 months ago (2013-10-14 11:06:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698