Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/full-codegen.cc

Issue 23684058: Unify handling of position info in AST, part 3 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 } 186 }
187 187
188 188
189 void BreakableStatementChecker::VisitDebuggerStatement( 189 void BreakableStatementChecker::VisitDebuggerStatement(
190 DebuggerStatement* stmt) { 190 DebuggerStatement* stmt) {
191 // The debugger statement is breakable. 191 // The debugger statement is breakable.
192 is_breakable_ = true; 192 is_breakable_ = true;
193 } 193 }
194 194
195 195
196 void BreakableStatementChecker::VisitCaseClause(CaseClause* clause) {
197 }
198
199
196 void BreakableStatementChecker::VisitFunctionLiteral(FunctionLiteral* expr) { 200 void BreakableStatementChecker::VisitFunctionLiteral(FunctionLiteral* expr) {
197 } 201 }
198 202
199 203
200 void BreakableStatementChecker::VisitSharedFunctionInfoLiteral( 204 void BreakableStatementChecker::VisitSharedFunctionInfoLiteral(
201 SharedFunctionInfoLiteral* expr) { 205 SharedFunctionInfoLiteral* expr) {
202 } 206 }
203 207
204 208
205 void BreakableStatementChecker::VisitConditional(Conditional* expr) { 209 void BreakableStatementChecker::VisitConditional(Conditional* expr) {
(...skipping 1302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1508 #ifdef ENABLE_DEBUGGER_SUPPORT 1512 #ifdef ENABLE_DEBUGGER_SUPPORT
1509 Comment cmnt(masm_, "[ DebuggerStatement"); 1513 Comment cmnt(masm_, "[ DebuggerStatement");
1510 SetStatementPosition(stmt); 1514 SetStatementPosition(stmt);
1511 1515
1512 __ DebugBreak(); 1516 __ DebugBreak();
1513 // Ignore the return value. 1517 // Ignore the return value.
1514 #endif 1518 #endif
1515 } 1519 }
1516 1520
1517 1521
1522 void FullCodeGenerator::VisitCaseClause(CaseClause* clause) {
1523 UNREACHABLE();
1524 }
1525
1526
1518 void FullCodeGenerator::VisitConditional(Conditional* expr) { 1527 void FullCodeGenerator::VisitConditional(Conditional* expr) {
1519 Comment cmnt(masm_, "[ Conditional"); 1528 Comment cmnt(masm_, "[ Conditional");
1520 Label true_case, false_case, done; 1529 Label true_case, false_case, done;
1521 VisitForControl(expr->condition(), &true_case, &false_case, &true_case); 1530 VisitForControl(expr->condition(), &true_case, &false_case, &true_case);
1522 1531
1523 PrepareForBailoutForId(expr->ThenId(), NO_REGISTERS); 1532 PrepareForBailoutForId(expr->ThenId(), NO_REGISTERS);
1524 __ bind(&true_case); 1533 __ bind(&true_case);
1525 SetExpressionPosition(expr->then_expression()); 1534 SetExpressionPosition(expr->then_expression());
1526 if (context()->IsTest()) { 1535 if (context()->IsTest()) {
1527 const TestContext* for_test = TestContext::cast(context()); 1536 const TestContext* for_test = TestContext::cast(context());
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1610 } 1619 }
1611 1620
1612 return false; 1621 return false;
1613 } 1622 }
1614 1623
1615 1624
1616 #undef __ 1625 #undef __
1617 1626
1618 1627
1619 } } // namespace v8::internal 1628 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698