Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: src/typing.cc

Issue 23684058: Unify handling of position info in AST, part 3 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/rewriter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 if (switch_type == SwitchStatement::SMI_SWITCH) { 199 if (switch_type == SwitchStatement::SMI_SWITCH) {
200 for (int i = 0; i < clauses->length(); ++i) { 200 for (int i = 0; i < clauses->length(); ++i) {
201 CaseClause* clause = clauses->at(i); 201 CaseClause* clause = clauses->at(i);
202 if (!clause->is_default()) 202 if (!clause->is_default())
203 clause->RecordTypeFeedback(oracle()); 203 clause->RecordTypeFeedback(oracle());
204 } 204 }
205 } 205 }
206 } 206 }
207 207
208 208
209 void AstTyper::VisitCaseClause(CaseClause* clause) {
210 UNREACHABLE();
211 }
212
213
209 void AstTyper::VisitDoWhileStatement(DoWhileStatement* stmt) { 214 void AstTyper::VisitDoWhileStatement(DoWhileStatement* stmt) {
210 // Collect type feedback. 215 // Collect type feedback.
211 if (!stmt->cond()->ToBooleanIsTrue()) { 216 if (!stmt->cond()->ToBooleanIsTrue()) {
212 stmt->cond()->RecordToBooleanTypeFeedback(oracle()); 217 stmt->cond()->RecordToBooleanTypeFeedback(oracle());
213 } 218 }
214 219
215 // TODO(rossberg): refine the unconditional Forget (here and elsewhere) by 220 // TODO(rossberg): refine the unconditional Forget (here and elsewhere) by
216 // computing the set of variables assigned in only some of the origins of the 221 // computing the set of variables assigned in only some of the origins of the
217 // control transfer (such as the loop body here). 222 // control transfer (such as the loop body here).
218 store_.Forget(); // Control may transfer here via looping or 'continue'. 223 store_.Forget(); // Control may transfer here via looping or 'continue'.
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 700 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
696 } 701 }
697 702
698 703
699 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 704 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
700 RECURSE(Visit(stmt->body())); 705 RECURSE(Visit(stmt->body()));
701 } 706 }
702 707
703 708
704 } } // namespace v8::internal 709 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/rewriter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698