Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2368343002: Revert auto-hide-invisible mode for ARC++ (Closed)

Created:
4 years, 2 months ago by oshima
Modified:
4 years, 2 months ago
Reviewers:
tdanderson, reveman, sky
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, awdf+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, kalyank, mlamouri+watch-notifications_chromium.org, oshima+watch_chromium.org, Peter Beverloo, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert auto-hide-invisible mode for ARC++ This was added in https://codereview.chromium.org/2248773002 to implement MD's new auto hide behavior for ARC++ windows. This is now default, so reverting that part. BUG=637883 Committed: https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787 Cr-Commit-Position: refs/heads/master@{#422147}

Patch Set 1 : Revert "Use MD-ash's auto hide behavior for arc++ windows." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -132 lines) Patch
M ash/common/shelf/shelf_layout_manager.h View 4 chunks +0 lines, -8 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 7 chunks +10 lines, -39 lines 0 comments Download
M ash/common/wm/immersive_context_ash.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/common/wm/window_state.h View 2 chunks +6 lines, -13 lines 0 comments Download
M ash/common/wm/window_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +2 lines, -41 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/notifications/fullscreen_notification_blocker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/exo/shell_surface.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
oshima
4 years, 2 months ago (2016-09-27 05:48:44 UTC) #10
tdanderson
lgtm
4 years, 2 months ago (2016-09-29 14:09:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368343002/20001
4 years, 2 months ago (2016-09-30 04:29:20 UTC) #16
oshima
reveman@ -> components/exo sky@ -> chrome/browser
4 years, 2 months ago (2016-09-30 04:30:51 UTC) #18
reveman
components/exo lgtm
4 years, 2 months ago (2016-09-30 06:04:00 UTC) #19
sky
LGTM
4 years, 2 months ago (2016-09-30 15:17:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368343002/20001
4 years, 2 months ago (2016-09-30 16:55:44 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-30 17:39:43 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:43:14 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787
Cr-Commit-Position: refs/heads/master@{#422147}

Powered by Google App Engine
This is Rietveld 408576698