chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc - Issue 2368343002: Revert auto-hide-invisible mode for ARC++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

Issue 2368343002: Revert auto-hide-invisible mode for ARC++ (Closed)

Patch Set: Revert "Use MD-ash's auto hide behavior for arc++ windows." Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

index 0a4c801d0c4b88eab8d75f84d4ed30f3f6faaff1..06f10585ffddfafcbe83e2abea13737717f83e40 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

@@ -358,9 +358,7 @@ void ImmersiveModeControllerAsh::Observe(

bool in_tab_fullscreen = content::Source<FullscreenController>(source)->

IsWindowFullscreenForTabOrPending();

ash::wm::GetWindowState(native_window_)

- ->set_shelf_mode_in_fullscreen(

- in_tab_fullscreen ? ash::wm::WindowState::SHELF_HIDDEN

- : ash::wm::WindowState::SHELF_AUTO_HIDE_VISIBLE);

+ ->set_hide_shelf_when_fullscreen(in_tab_fullscreen);

ash::Shell::GetInstance()->UpdateShelfVisibility();

if (tab_indicator_visibility_changed)