Remove usage of BalsaHeaders from QuicClient. Also move QuicDataToResend from QuicClient to QuicCli…

Remove usage of BalsaHeaders from QuicClient. Also move QuicDataToResend from QuicClient to QuicClientBase

Merge internal change: 134215647

Committed: https://crrev.com/c29e68c00c797b34673bba029ac81cccc98598ab
Cr-Commit-Position: refs/heads/master@{#421260}

[Ryan Hamilton, 2016-09-26 19:58:08]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Zhongyi Shi, 2016-09-26 21:12:55]

lgtm

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/quic_client.h
File net/tools/quic/quic_client.h (left):

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/quic_client....
net/tools/quic/quic_client.h:23: #include "net/tools/balsa/balsa_headers.h"
nit: could you also help remove
https://cs.chromium.org/chromium/src/net/tools/quic/test_tools/simple_client....

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/test_tools/q...
File net/tools/quic/test_tools/quic_test_client.cc (right):

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/test_tools/q...
net/tools/quic/test_tools/quic_test_client.cc:25: #include
"net/tools/balsa/balsa_headers.h"
nit: remove the include?

[Ryan Hamilton, 2016-09-26 21:52:56]

Thanks!

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/quic_client.h
File net/tools/quic/quic_client.h (left):

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/quic_client....
net/tools/quic/quic_client.h:23: #include "net/tools/balsa/balsa_headers.h"
On 2016/09/26 21:12:55, Zhongyi Shi wrote:
> nit: could you also help remove
>
https://cs.chromium.org/chromium/src/net/tools/quic/test_tools/simple_client....

Working on it, but not there yet, alas.

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/test_tools/q...
File net/tools/quic/test_tools/quic_test_client.cc (right):

https://codereview.chromium.org/2363393004/diff/1/net/tools/quic/test_tools/q...
net/tools/quic/test_tools/quic_test_client.cc:25: #include
"net/tools/balsa/balsa_headers.h"
On 2016/09/26 21:12:55, Zhongyi Shi wrote:
> nit: remove the include?

Alas, the QuicTestClient is still using BalsaHeaders. I can't remove this ...
yet.

[Ryan Hamilton, 2016-09-26 21:53:04]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 21:54:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 22:24:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2016-09-27 03:52:12]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 03:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-09-27 03:57:40]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 03:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 04:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 04:32:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ryan Hamilton, 2016-09-27 16:31:23]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-09-27 16:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from zhongyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2363393004/#ps80001
(title: "Fix win")

[commit-bot: I haz the power, 2016-09-27 16:32:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 17:58:05]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-27 18:02:23]

Description was changed from

==========
Remove usage of BalsaHeaders from QuicClient. Also move QuicDataToResend from
QuicClient to QuicClientBase

Merge internal change: 134215647
==========

to

==========
Remove usage of BalsaHeaders from QuicClient. Also move QuicDataToResend from
QuicClient to QuicClientBase

Merge internal change: 134215647

Committed: https://crrev.com/c29e68c00c797b34673bba029ac81cccc98598ab
Cr-Commit-Position: refs/heads/master@{#421260}
==========

[commit-bot: I haz the power, 2016-09-27 18:02:24]

Patchset 5 (id:??) landed as
https://crrev.com/c29e68c00c797b34673bba029ac81cccc98598ab
Cr-Commit-Position: refs/heads/master@{#421260}