chrome/renderer/extensions/app_window_custom_bindings.cc - Issue 23679004: Remove more calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_window_custom_bindings.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/app_window_custom_bindings.cc

diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc

index 3c94d576fc0c3d3f2a6b90159b65f33000dbf52f..7bbd76f31091e5c1521b393f65c3855e59c86310 100644

--- a/chrome/renderer/extensions/app_window_custom_bindings.cc

+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc

@@ -38,7 +38,7 @@ class DidCreateDocumentElementObserver : public content::RenderViewObserver {

// Don't attempt to inject the titlebar into iframes.

if (frame->parent())

return;

- v8::HandleScope handle_scope;

+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());

ChromeV8Context* v8_context =

dispatcher_->v8_context_set().GetByV8Context(

frame->mainWorldScriptContext());