chrome/renderer/extensions/app_bindings.cc - Issue 23679004: Remove more calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_bindings.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/app_bindings.cc

diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc

index 41238e74c31ceecd777ff849ed10c59eb6448529..db3888b9ebb037581c170be1676eaa5434248d69 100644

--- a/chrome/renderer/extensions/app_bindings.cc

+++ b/chrome/renderer/extensions/app_bindings.cc

@@ -207,7 +207,7 @@ bool AppBindings::OnMessageReceived(const IPC::Message& message) {

void AppBindings::OnAppInstallStateResponse(

const std::string& state, int callback_id) {

- v8::HandleScope handle_scope;

+ v8::HandleScope handle_scope(context()->isolate());

v8::Context::Scope context_scope(context()->v8_context());

v8::Handle<v8::Value> argv[] = {

v8::String::New(state.c_str()),