chrome/renderer/extensions/binding_generating_native_handler.cc - Issue 23679004: Remove more calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/binding_generating_native_handler.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/binding_generating_native_handler.cc

diff --git a/chrome/renderer/extensions/binding_generating_native_handler.cc b/chrome/renderer/extensions/binding_generating_native_handler.cc

index 3bb18aceb7321873ee43b4a2b8f8b31656e9e8c6..f001c1f1c6d6bd3e53b8f81b923eb3a9fa534258 100644

--- a/chrome/renderer/extensions/binding_generating_native_handler.cc

+++ b/chrome/renderer/extensions/binding_generating_native_handler.cc

@@ -18,7 +18,7 @@ BindingGeneratingNativeHandler::BindingGeneratingNativeHandler(

}

v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {

- v8::HandleScope scope;

+ v8::HandleScope scope(module_system_->GetIsolate());

v8::Handle<v8::Object> binding_module =

module_system_->Require("binding")->ToObject();

v8::Handle<v8::Object> binding =