| Index: test/unittests/compiler/simplified-operator-reducer-unittest.cc
|
| diff --git a/test/unittests/compiler/simplified-operator-reducer-unittest.cc b/test/unittests/compiler/simplified-operator-reducer-unittest.cc
|
| index d50d2ff4ef0ddfc03c7a4e270f90c761fe1c671f..6f37609f3a0e5559c3b0a06d810653ab05efaae2 100644
|
| --- a/test/unittests/compiler/simplified-operator-reducer-unittest.cc
|
| +++ b/test/unittests/compiler/simplified-operator-reducer-unittest.cc
|
| @@ -97,10 +97,6 @@ const double kNaNs[] = {-std::numeric_limits<double>::quiet_NaN(),
|
| bit_cast<double>(V8_UINT64_C(0x7FFFFFFFFFFFFFFF)),
|
| bit_cast<double>(V8_UINT64_C(0xFFFFFFFFFFFFFFFF))};
|
|
|
| -const CheckForMinusZeroMode kCheckForMinusZeroModes[] = {
|
| - CheckForMinusZeroMode::kDontCheckForMinusZero,
|
| - CheckForMinusZeroMode::kCheckForMinusZero};
|
| -
|
| } // namespace
|
|
|
|
|
| @@ -191,13 +187,11 @@ TEST_F(SimplifiedOperatorReducerTest, ChangeTaggedToBitWithChangeBitToTagged) {
|
| // ChangeFloat64ToTagged
|
|
|
| TEST_F(SimplifiedOperatorReducerTest, ChangeFloat64ToTaggedWithConstant) {
|
| - TRACED_FOREACH(CheckForMinusZeroMode, mode, kCheckForMinusZeroModes) {
|
| - TRACED_FOREACH(double, n, kFloat64Values) {
|
| - Reduction reduction = Reduce(graph()->NewNode(
|
| - simplified()->ChangeFloat64ToTagged(mode), Float64Constant(n)));
|
| - ASSERT_TRUE(reduction.Changed());
|
| - EXPECT_THAT(reduction.replacement(), IsNumberConstant(BitEq(n)));
|
| - }
|
| + TRACED_FOREACH(double, n, kFloat64Values) {
|
| + Reduction reduction = Reduce(graph()->NewNode(
|
| + simplified()->ChangeFloat64ToTagged(), Float64Constant(n)));
|
| + ASSERT_TRUE(reduction.Changed());
|
| + EXPECT_THAT(reduction.replacement(), IsNumberConstant(BitEq(n)));
|
| }
|
| }
|
|
|
| @@ -222,13 +216,11 @@ TEST_F(SimplifiedOperatorReducerTest, ChangeInt32ToTaggedWithConstant) {
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| ChangeTaggedToFloat64WithChangeFloat64ToTagged) {
|
| Node* param0 = Parameter(0);
|
| - TRACED_FOREACH(CheckForMinusZeroMode, mode, kCheckForMinusZeroModes) {
|
| - Reduction reduction = Reduce(graph()->NewNode(
|
| - simplified()->ChangeTaggedToFloat64(),
|
| - graph()->NewNode(simplified()->ChangeFloat64ToTagged(mode), param0)));
|
| - ASSERT_TRUE(reduction.Changed());
|
| - EXPECT_EQ(param0, reduction.replacement());
|
| - }
|
| + Reduction reduction = Reduce(graph()->NewNode(
|
| + simplified()->ChangeTaggedToFloat64(),
|
| + graph()->NewNode(simplified()->ChangeFloat64ToTagged(), param0)));
|
| + ASSERT_TRUE(reduction.Changed());
|
| + EXPECT_EQ(param0, reduction.replacement());
|
| }
|
|
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| @@ -279,13 +271,11 @@ TEST_F(SimplifiedOperatorReducerTest, ChangeTaggedToFloat64WithNaNConstant) {
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| ChangeTaggedToInt32WithChangeFloat64ToTagged) {
|
| Node* param0 = Parameter(0);
|
| - TRACED_FOREACH(CheckForMinusZeroMode, mode, kCheckForMinusZeroModes) {
|
| - Reduction reduction = Reduce(graph()->NewNode(
|
| - simplified()->ChangeTaggedToInt32(),
|
| - graph()->NewNode(simplified()->ChangeFloat64ToTagged(mode), param0)));
|
| - ASSERT_TRUE(reduction.Changed());
|
| - EXPECT_THAT(reduction.replacement(), IsChangeFloat64ToInt32(param0));
|
| - }
|
| + Reduction reduction = Reduce(graph()->NewNode(
|
| + simplified()->ChangeTaggedToInt32(),
|
| + graph()->NewNode(simplified()->ChangeFloat64ToTagged(), param0)));
|
| + ASSERT_TRUE(reduction.Changed());
|
| + EXPECT_THAT(reduction.replacement(), IsChangeFloat64ToInt32(param0));
|
| }
|
|
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| @@ -305,13 +295,11 @@ TEST_F(SimplifiedOperatorReducerTest,
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| ChangeTaggedToUint32WithChangeFloat64ToTagged) {
|
| Node* param0 = Parameter(0);
|
| - TRACED_FOREACH(CheckForMinusZeroMode, mode, kCheckForMinusZeroModes) {
|
| - Reduction reduction = Reduce(graph()->NewNode(
|
| - simplified()->ChangeTaggedToUint32(),
|
| - graph()->NewNode(simplified()->ChangeFloat64ToTagged(mode), param0)));
|
| - ASSERT_TRUE(reduction.Changed());
|
| - EXPECT_THAT(reduction.replacement(), IsChangeFloat64ToUint32(param0));
|
| - }
|
| + Reduction reduction = Reduce(graph()->NewNode(
|
| + simplified()->ChangeTaggedToUint32(),
|
| + graph()->NewNode(simplified()->ChangeFloat64ToTagged(), param0)));
|
| + ASSERT_TRUE(reduction.Changed());
|
| + EXPECT_THAT(reduction.replacement(), IsChangeFloat64ToUint32(param0));
|
| }
|
|
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| @@ -331,13 +319,11 @@ TEST_F(SimplifiedOperatorReducerTest,
|
| TEST_F(SimplifiedOperatorReducerTest,
|
| TruncateTaggedToWord3WithChangeFloat64ToTagged) {
|
| Node* param0 = Parameter(0);
|
| - TRACED_FOREACH(CheckForMinusZeroMode, mode, kCheckForMinusZeroModes) {
|
| - Reduction reduction = Reduce(graph()->NewNode(
|
| - simplified()->TruncateTaggedToWord32(),
|
| - graph()->NewNode(simplified()->ChangeFloat64ToTagged(mode), param0)));
|
| - ASSERT_TRUE(reduction.Changed());
|
| - EXPECT_THAT(reduction.replacement(), IsTruncateFloat64ToWord32(param0));
|
| - }
|
| + Reduction reduction = Reduce(graph()->NewNode(
|
| + simplified()->TruncateTaggedToWord32(),
|
| + graph()->NewNode(simplified()->ChangeFloat64ToTagged(), param0)));
|
| + ASSERT_TRUE(reduction.Changed());
|
| + EXPECT_THAT(reduction.replacement(), IsTruncateFloat64ToWord32(param0));
|
| }
|
|
|
| TEST_F(SimplifiedOperatorReducerTest, TruncateTaggedToWord32WithConstant) {
|
|
|