Track the ratio of received GCM messages for registered applications

Track the ratio of received GCM messages for registered applications

BUG=

Committed: https://crrev.com/9613b0ae8c7cb994334454b13ca231cc2c1494a4
Cr-Commit-Position: refs/heads/master@{#421524}

[Peter Beverloo, 2016-09-26 13:23:40]

peter@chromium.org changed reviewers:
+ johnme@chromium.org, ricea@chromium.org

[Peter Beverloo, 2016-09-26 13:23:41]

+johnme for GCM, ricea for histograms

[johnme, 2016-09-26 13:29:13]

lgtm with nits

https://codereview.chromium.org/2367373002/diff/1/components/gcm_driver/gcm_s...
File components/gcm_driver/gcm_stats_recorder_android.cc (right):

https://codereview.chromium.org/2367373002/diff/1/components/gcm_driver/gcm_s...
components/gcm_driver/gcm_stats_recorder_android.cc:111:
UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceivedHasRegisteredApp", true);
I'd lean towards not logging this - it feels misleading, since it looks as if no
messages are lost on android, when really we just don't know about them.

https://codereview.chromium.org/2367373002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2367373002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:17691: +    Records whether a the
registration associated to a received DATA_MESSAGE
How about: "Records whether a corresponding registration was found for each
received DATA_MESSAGE or DELETED_MESSAGES message from Google Cloud Messaging."

In any case, fix the "a the" :)

[Peter Beverloo, 2016-09-26 13:31:43]

https://codereview.chromium.org/2367373002/diff/1/components/gcm_driver/gcm_s...
File components/gcm_driver/gcm_stats_recorder_android.cc (right):

https://codereview.chromium.org/2367373002/diff/1/components/gcm_driver/gcm_s...
components/gcm_driver/gcm_stats_recorder_android.cc:111:
UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceivedHasRegisteredApp", true);
On 2016/09/26 13:29:13, johnme wrote:
> I'd lean towards not logging this - it feels misleading, since it looks as if
no
> messages are lost on android, when really we just don't know about them.

Done.

https://codereview.chromium.org/2367373002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2367373002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:17691: +    Records whether a the
registration associated to a received DATA_MESSAGE
On 2016/09/26 13:29:13, johnme wrote:
> How about: "Records whether a corresponding registration was found for each
> received DATA_MESSAGE or DELETED_MESSAGES message from Google Cloud
Messaging."
> 
> In any case, fix the "a the" :)

Done.

[Peter Beverloo, 2016-09-26 13:37:12]

peter@chromium.org changed reviewers:
+ asvitkine@chromium.org
- ricea@chromium.org

[Peter Beverloo, 2016-09-26 13:37:13]

s/ricea/asvitkine/ for histograms :)

[Alexei Svitkine (slow), 2016-09-26 14:38:37]

lgtm

[Peter Beverloo, 2016-09-28 14:36:48]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-09-28 14:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org
Link to the patchset: https://codereview.chromium.org/2367373002/#ps20001
(title: "Track the ratio of received GCM messages for registered applications")

[commit-bot: I haz the power, 2016-09-28 14:37:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:25:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 15:27:02]

Description was changed from

==========
Track the ratio of received GCM messages for registered applications

BUG=
==========

to

==========
Track the ratio of received GCM messages for registered applications

BUG=

Committed: https://crrev.com/9613b0ae8c7cb994334454b13ca231cc2c1494a4
Cr-Commit-Position: refs/heads/master@{#421524}
==========

[commit-bot: I haz the power, 2016-09-28 15:27:03]

Patchset 2 (id:??) landed as
https://crrev.com/9613b0ae8c7cb994334454b13ca231cc2c1494a4
Cr-Commit-Position: refs/heads/master@{#421524}