Track the ratio of received GCM messages for registered applications

components/gcm_driver/gcm_stats_recorder_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "components/gcm_driver/gcm_stats_recorder_android.h"
 
 namespace gcm {
 
@@ skipping 88 matching lines @@
     registration_activities_.pop_back();
 
   if (delegate_)
     delegate_->OnActivityRecorded();
 }
 
 void GCMStatsRecorderAndroid::RecordDataMessageReceived(
     const std::string& app_id,
     const std::string& from,
     int message_byte_size) {
+  // Active registrations are maintained by Android, not Chrome, so any
+  // received data message is per definition still registered.
+  UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceivedHasRegisteredApp", true);

[johnme, 2016/09/26 13:29:13]

I'd lean towards not logging this - it feels misleading, since it looks as if no
messages are lost on android, when really we just don't know about them.

[Peter Beverloo, 2016/09/26 13:31:42]

Done.

+
   if (!is_recording_)
     return;
 
   ReceivingActivity activity;
   activity.app_id = app_id;
   activity.from = from;
   activity.message_byte_size = message_byte_size;
   activity.event = "Data msg received";
 
   receiving_activities_.push_front(activity);
@@ skipping 19 matching lines @@
 
   decryption_failure_activities_.push_front(activity);
   if (decryption_failure_activities_.size() > MAX_LOGGED_ACTIVITY_COUNT)
     decryption_failure_activities_.pop_back();
 
   if (delegate_)
     delegate_->OnActivityRecorded();
 }
 
 }  // namespace gcm