Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2365363002: Create mappings for unmapped GCM-related histograms (Closed)

Created:
4 years, 2 months ago by Peter Beverloo
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Adam Rice
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create mappings for unmapped GCM-related histograms BUG=643545 Committed: https://crrev.com/d91a3c3fbca28503c5375150db219c2182e3d576 Cr-Commit-Position: refs/heads/master@{#421167}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Create mappings for unmapped GCM-related histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 6 chunks +52 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Peter Beverloo
+johnme for GCM, ricea for histograms
4 years, 2 months ago (2016-09-26 13:12:54 UTC) #2
johnme
lgtm https://codereview.chromium.org/2365363002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2365363002/diff/1/tools/metrics/histograms/histograms.xml#newcode83680 tools/metrics/histograms/histograms.xml:83680: +<enum name="GCMMessageSendStatus" type="int"> Nit: GCMSendMessageStatus for consistency?
4 years, 2 months ago (2016-09-26 13:24:40 UTC) #3
Peter Beverloo
https://codereview.chromium.org/2365363002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2365363002/diff/1/tools/metrics/histograms/histograms.xml#newcode83680 tools/metrics/histograms/histograms.xml:83680: +<enum name="GCMMessageSendStatus" type="int"> On 2016/09/26 13:24:40, johnme wrote: > ...
4 years, 2 months ago (2016-09-26 13:27:31 UTC) #4
Peter Beverloo
s/ricea/asvitkine/ for histograms :)
4 years, 2 months ago (2016-09-26 13:36:45 UTC) #6
Alexei Svitkine (slow)
lgtm, but please consider removing these in a follow-up CL if you're not actually using ...
4 years, 2 months ago (2016-09-26 14:38:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365363002/20001
4 years, 2 months ago (2016-09-27 10:17:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 11:05:54 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 11:07:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d91a3c3fbca28503c5375150db219c2182e3d576
Cr-Commit-Position: refs/heads/master@{#421167}

Powered by Google App Engine
This is Rietveld 408576698