Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ff0c1a487b941b11478790642d92e94a1e765248
Cr-Commit-Position: refs/heads/master@{#432376}

[sashab, 2016-09-26 06:24:51]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords
(WIP)

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords
(WIP)

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-11-15 04:06:46]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 04:07:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-15 04:09:06]

sashab@chromium.org changed reviewers:
+ bugsnash@chromium.org

[sashab, 2016-11-15 04:09:25]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords
(WIP)

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-11-15 04:09:35]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
==========

[sashab, 2016-11-15 04:15:09]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org
- bugsnash@chromium.org

[sashab, 2016-11-15 04:15:09]

Bugs is heading out next week and needs to focus on own work - naina ptal? low
priority, pretty straightforward patch

[sashab, 2016-11-15 04:16:59]

sashab@chromium.org changed reviewers:
+ bugsnash@chromium.org
- nainar@chromium.org

[sashab, 2016-11-15 04:17:00]

Nvm bugs is being super nice and helping me out anyway. (Y)

[sashab, 2016-11-15 04:20:37]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EListStyleType to be
generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
==========

[Bugs Nash, 2016-11-15 04:21:51]

On 2016/11/15 at 04:17:00, sashab wrote:
> Nvm bugs is being super nice and helping me out anyway. (Y)

lgtm, please add link to design doc in bug

[sashab, 2016-11-15 04:24:07]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org

[sashab, 2016-11-15 04:24:08]

Done, ty.

nainar@ please RS.

[nainar, 2016-11-15 04:28:41]

On 2016/11/15 at 04:24:08, sashab wrote:
> Done, ty.
> 
> nainar@ please RS.

lgtm assuming this build error is a trivial fix - please comment here if not.
Thanks!

[commit-bot: I haz the power, 2016-11-15 04:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 04:32:46]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-11-16 02:13:42]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 02:14:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-16 02:14:48]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-11-16 02:15:00]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 02:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 03:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:51:47]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sashab, 2016-11-16 05:35:08]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-16 05:35:09]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2367293002/#ps40001
(title: "Final patch + formatting")

[commit-bot: I haz the power, 2016-11-16 05:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 06:12:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 06:15:38]

Description was changed from

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EListStyleType to an enum class and renamed its members to keywords

Changed EListStyleType to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EListStyleType to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ff0c1a487b941b11478790642d92e94a1e765248
Cr-Commit-Position: refs/heads/master@{#432376}
==========

[commit-bot: I haz the power, 2016-11-16 06:15:39]

Patchset 3 (id:??) landed as
https://crrev.com/ff0c1a487b941b11478790642d92e94a1e765248
Cr-Commit-Position: refs/heads/master@{#432376}