third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2367293002: Changed EListStyleType to an enum class and renamed its members to keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2367293002: Changed EListStyleType to an enum class and renamed its members to keywords (Closed)

Patch Set: Final patch + formatting Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index acbc03e5766f9903ec16a22f27d14748ae6aa8a0..0c8ab2472cb5acb14d08a98fa94207d8f447c4ba 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1481,9 +1481,12 @@ static CSSValue* valueForContentData(const ComputedStyle& style) {

CSSCustomIdentValue::create(counter->identifier());

CSSStringValue* separator = CSSStringValue::create(counter->separator());

CSSValueID listStyleIdent = CSSValueNone;

- if (counter->listStyle() != NoneListStyle)

+ if (counter->listStyle() != EListStyleType::NoneListStyle) {

+ // TODO(sashab): Change this to use a converter instead of

+ // CSSPrimitiveValueMappings.

listStyleIdent =

- static_cast<CSSValueID>(CSSValueDisc + counter->listStyle());

+ CSSIdentifierValue::create(counter->listStyle())->getValueID();

+ }

CSSIdentifierValue* listStyle =

CSSIdentifierValue::create(listStyleIdent);

list->append(*CSSCounterValue::create(identifier, listStyle, separator));