Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2367293002: Changed EListStyleType to an enum class and renamed its members to keywords (Closed)
Patch Set: Final patch + formatting Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 1439 matching lines...) Expand 10 before | Expand all | Expand 10 after
1450 } 1450 }
1451 1451
1452 ASSERT_NOT_REACHED(); 1452 ASSERT_NOT_REACHED();
1453 return EListStylePosition::Outside; 1453 return EListStylePosition::Outside;
1454 } 1454 }
1455 1455
1456 template <> 1456 template <>
1457 inline CSSIdentifierValue::CSSIdentifierValue(EListStyleType e) 1457 inline CSSIdentifierValue::CSSIdentifierValue(EListStyleType e)
1458 : CSSValue(IdentifierClass) { 1458 : CSSValue(IdentifierClass) {
1459 switch (e) { 1459 switch (e) {
1460 case ArabicIndic: 1460 case EListStyleType::ArabicIndic:
1461 m_valueID = CSSValueArabicIndic; 1461 m_valueID = CSSValueArabicIndic;
1462 break; 1462 break;
1463 case Armenian: 1463 case EListStyleType::Armenian:
1464 m_valueID = CSSValueArmenian; 1464 m_valueID = CSSValueArmenian;
1465 break; 1465 break;
1466 case Bengali: 1466 case EListStyleType::Bengali:
1467 m_valueID = CSSValueBengali; 1467 m_valueID = CSSValueBengali;
1468 break; 1468 break;
1469 case Cambodian: 1469 case EListStyleType::Cambodian:
1470 m_valueID = CSSValueCambodian; 1470 m_valueID = CSSValueCambodian;
1471 break; 1471 break;
1472 case Circle: 1472 case EListStyleType::Circle:
1473 m_valueID = CSSValueCircle; 1473 m_valueID = CSSValueCircle;
1474 break; 1474 break;
1475 case CjkEarthlyBranch: 1475 case EListStyleType::CjkEarthlyBranch:
1476 m_valueID = CSSValueCjkEarthlyBranch; 1476 m_valueID = CSSValueCjkEarthlyBranch;
1477 break; 1477 break;
1478 case CjkHeavenlyStem: 1478 case EListStyleType::CjkHeavenlyStem:
1479 m_valueID = CSSValueCjkHeavenlyStem; 1479 m_valueID = CSSValueCjkHeavenlyStem;
1480 break; 1480 break;
1481 case CJKIdeographic: 1481 case EListStyleType::CJKIdeographic:
1482 m_valueID = CSSValueCjkIdeographic; 1482 m_valueID = CSSValueCjkIdeographic;
1483 break; 1483 break;
1484 case DecimalLeadingZero: 1484 case EListStyleType::DecimalLeadingZero:
1485 m_valueID = CSSValueDecimalLeadingZero; 1485 m_valueID = CSSValueDecimalLeadingZero;
1486 break; 1486 break;
1487 case DecimalListStyle: 1487 case EListStyleType::DecimalListStyle:
1488 m_valueID = CSSValueDecimal; 1488 m_valueID = CSSValueDecimal;
1489 break; 1489 break;
1490 case Devanagari: 1490 case EListStyleType::Devanagari:
1491 m_valueID = CSSValueDevanagari; 1491 m_valueID = CSSValueDevanagari;
1492 break; 1492 break;
1493 case Disc: 1493 case EListStyleType::Disc:
1494 m_valueID = CSSValueDisc; 1494 m_valueID = CSSValueDisc;
1495 break; 1495 break;
1496 case EthiopicHalehame: 1496 case EListStyleType::EthiopicHalehame:
1497 m_valueID = CSSValueEthiopicHalehame; 1497 m_valueID = CSSValueEthiopicHalehame;
1498 break; 1498 break;
1499 case EthiopicHalehameAm: 1499 case EListStyleType::EthiopicHalehameAm:
1500 m_valueID = CSSValueEthiopicHalehameAm; 1500 m_valueID = CSSValueEthiopicHalehameAm;
1501 break; 1501 break;
1502 case EthiopicHalehameTiEt: 1502 case EListStyleType::EthiopicHalehameTiEt:
1503 m_valueID = CSSValueEthiopicHalehameTiEt; 1503 m_valueID = CSSValueEthiopicHalehameTiEt;
1504 break; 1504 break;
1505 case EthiopicHalehameTiEr: 1505 case EListStyleType::EthiopicHalehameTiEr:
1506 m_valueID = CSSValueEthiopicHalehameTiEr; 1506 m_valueID = CSSValueEthiopicHalehameTiEr;
1507 break; 1507 break;
1508 case Georgian: 1508 case EListStyleType::Georgian:
1509 m_valueID = CSSValueGeorgian; 1509 m_valueID = CSSValueGeorgian;
1510 break; 1510 break;
1511 case Gujarati: 1511 case EListStyleType::Gujarati:
1512 m_valueID = CSSValueGujarati; 1512 m_valueID = CSSValueGujarati;
1513 break; 1513 break;
1514 case Gurmukhi: 1514 case EListStyleType::Gurmukhi:
1515 m_valueID = CSSValueGurmukhi; 1515 m_valueID = CSSValueGurmukhi;
1516 break; 1516 break;
1517 case Hangul: 1517 case EListStyleType::Hangul:
1518 m_valueID = CSSValueHangul; 1518 m_valueID = CSSValueHangul;
1519 break; 1519 break;
1520 case HangulConsonant: 1520 case EListStyleType::HangulConsonant:
1521 m_valueID = CSSValueHangulConsonant; 1521 m_valueID = CSSValueHangulConsonant;
1522 break; 1522 break;
1523 case KoreanHangulFormal: 1523 case EListStyleType::KoreanHangulFormal:
1524 m_valueID = CSSValueKoreanHangulFormal; 1524 m_valueID = CSSValueKoreanHangulFormal;
1525 break; 1525 break;
1526 case KoreanHanjaFormal: 1526 case EListStyleType::KoreanHanjaFormal:
1527 m_valueID = CSSValueKoreanHanjaFormal; 1527 m_valueID = CSSValueKoreanHanjaFormal;
1528 break; 1528 break;
1529 case KoreanHanjaInformal: 1529 case EListStyleType::KoreanHanjaInformal:
1530 m_valueID = CSSValueKoreanHanjaInformal; 1530 m_valueID = CSSValueKoreanHanjaInformal;
1531 break; 1531 break;
1532 case Hebrew: 1532 case EListStyleType::Hebrew:
1533 m_valueID = CSSValueHebrew; 1533 m_valueID = CSSValueHebrew;
1534 break; 1534 break;
1535 case Hiragana: 1535 case EListStyleType::Hiragana:
1536 m_valueID = CSSValueHiragana; 1536 m_valueID = CSSValueHiragana;
1537 break; 1537 break;
1538 case HiraganaIroha: 1538 case EListStyleType::HiraganaIroha:
1539 m_valueID = CSSValueHiraganaIroha; 1539 m_valueID = CSSValueHiraganaIroha;
1540 break; 1540 break;
1541 case Kannada: 1541 case EListStyleType::Kannada:
1542 m_valueID = CSSValueKannada; 1542 m_valueID = CSSValueKannada;
1543 break; 1543 break;
1544 case Katakana: 1544 case EListStyleType::Katakana:
1545 m_valueID = CSSValueKatakana; 1545 m_valueID = CSSValueKatakana;
1546 break; 1546 break;
1547 case KatakanaIroha: 1547 case EListStyleType::KatakanaIroha:
1548 m_valueID = CSSValueKatakanaIroha; 1548 m_valueID = CSSValueKatakanaIroha;
1549 break; 1549 break;
1550 case Khmer: 1550 case EListStyleType::Khmer:
1551 m_valueID = CSSValueKhmer; 1551 m_valueID = CSSValueKhmer;
1552 break; 1552 break;
1553 case Lao: 1553 case EListStyleType::Lao:
1554 m_valueID = CSSValueLao; 1554 m_valueID = CSSValueLao;
1555 break; 1555 break;
1556 case LowerAlpha: 1556 case EListStyleType::LowerAlpha:
1557 m_valueID = CSSValueLowerAlpha; 1557 m_valueID = CSSValueLowerAlpha;
1558 break; 1558 break;
1559 case LowerArmenian: 1559 case EListStyleType::LowerArmenian:
1560 m_valueID = CSSValueLowerArmenian; 1560 m_valueID = CSSValueLowerArmenian;
1561 break; 1561 break;
1562 case LowerGreek: 1562 case EListStyleType::LowerGreek:
1563 m_valueID = CSSValueLowerGreek; 1563 m_valueID = CSSValueLowerGreek;
1564 break; 1564 break;
1565 case LowerLatin: 1565 case EListStyleType::LowerLatin:
1566 m_valueID = CSSValueLowerLatin; 1566 m_valueID = CSSValueLowerLatin;
1567 break; 1567 break;
1568 case LowerRoman: 1568 case EListStyleType::LowerRoman:
1569 m_valueID = CSSValueLowerRoman; 1569 m_valueID = CSSValueLowerRoman;
1570 break; 1570 break;
1571 case Malayalam: 1571 case EListStyleType::Malayalam:
1572 m_valueID = CSSValueMalayalam; 1572 m_valueID = CSSValueMalayalam;
1573 break; 1573 break;
1574 case Mongolian: 1574 case EListStyleType::Mongolian:
1575 m_valueID = CSSValueMongolian; 1575 m_valueID = CSSValueMongolian;
1576 break; 1576 break;
1577 case Myanmar: 1577 case EListStyleType::Myanmar:
1578 m_valueID = CSSValueMyanmar; 1578 m_valueID = CSSValueMyanmar;
1579 break; 1579 break;
1580 case NoneListStyle: 1580 case EListStyleType::NoneListStyle:
1581 m_valueID = CSSValueNone; 1581 m_valueID = CSSValueNone;
1582 break; 1582 break;
1583 case Oriya: 1583 case EListStyleType::Oriya:
1584 m_valueID = CSSValueOriya; 1584 m_valueID = CSSValueOriya;
1585 break; 1585 break;
1586 case Persian: 1586 case EListStyleType::Persian:
1587 m_valueID = CSSValuePersian; 1587 m_valueID = CSSValuePersian;
1588 break; 1588 break;
1589 case SimpChineseFormal: 1589 case EListStyleType::SimpChineseFormal:
1590 m_valueID = CSSValueSimpChineseFormal; 1590 m_valueID = CSSValueSimpChineseFormal;
1591 break; 1591 break;
1592 case SimpChineseInformal: 1592 case EListStyleType::SimpChineseInformal:
1593 m_valueID = CSSValueSimpChineseInformal; 1593 m_valueID = CSSValueSimpChineseInformal;
1594 break; 1594 break;
1595 case Square: 1595 case EListStyleType::Square:
1596 m_valueID = CSSValueSquare; 1596 m_valueID = CSSValueSquare;
1597 break; 1597 break;
1598 case Telugu: 1598 case EListStyleType::Telugu:
1599 m_valueID = CSSValueTelugu; 1599 m_valueID = CSSValueTelugu;
1600 break; 1600 break;
1601 case Thai: 1601 case EListStyleType::Thai:
1602 m_valueID = CSSValueThai; 1602 m_valueID = CSSValueThai;
1603 break; 1603 break;
1604 case Tibetan: 1604 case EListStyleType::Tibetan:
1605 m_valueID = CSSValueTibetan; 1605 m_valueID = CSSValueTibetan;
1606 break; 1606 break;
1607 case TradChineseFormal: 1607 case EListStyleType::TradChineseFormal:
1608 m_valueID = CSSValueTradChineseFormal; 1608 m_valueID = CSSValueTradChineseFormal;
1609 break; 1609 break;
1610 case TradChineseInformal: 1610 case EListStyleType::TradChineseInformal:
1611 m_valueID = CSSValueTradChineseInformal; 1611 m_valueID = CSSValueTradChineseInformal;
1612 break; 1612 break;
1613 case UpperAlpha: 1613 case EListStyleType::UpperAlpha:
1614 m_valueID = CSSValueUpperAlpha; 1614 m_valueID = CSSValueUpperAlpha;
1615 break; 1615 break;
1616 case UpperArmenian: 1616 case EListStyleType::UpperArmenian:
1617 m_valueID = CSSValueUpperArmenian; 1617 m_valueID = CSSValueUpperArmenian;
1618 break; 1618 break;
1619 case UpperLatin: 1619 case EListStyleType::UpperLatin:
1620 m_valueID = CSSValueUpperLatin; 1620 m_valueID = CSSValueUpperLatin;
1621 break; 1621 break;
1622 case UpperRoman: 1622 case EListStyleType::UpperRoman:
1623 m_valueID = CSSValueUpperRoman; 1623 m_valueID = CSSValueUpperRoman;
1624 break; 1624 break;
1625 case Urdu: 1625 case EListStyleType::Urdu:
1626 m_valueID = CSSValueUrdu; 1626 m_valueID = CSSValueUrdu;
1627 break; 1627 break;
1628 } 1628 }
1629 } 1629 }
1630 1630
1631 template <> 1631 template <>
1632 inline EListStyleType CSSIdentifierValue::convertTo() const { 1632 inline EListStyleType CSSIdentifierValue::convertTo() const {
1633 switch (m_valueID) { 1633 switch (m_valueID) {
1634 case CSSValueNone: 1634 case CSSValueNone:
1635 return NoneListStyle; 1635 return EListStyleType::NoneListStyle;
1636 case CSSValueArabicIndic:
1637 return EListStyleType::ArabicIndic;
1638 case CSSValueArmenian:
1639 return EListStyleType::Armenian;
1640 case CSSValueBengali:
1641 return EListStyleType::Bengali;
1642 case CSSValueCambodian:
1643 return EListStyleType::Cambodian;
1644 case CSSValueCircle:
1645 return EListStyleType::Circle;
1646 case CSSValueCjkEarthlyBranch:
1647 return EListStyleType::CjkEarthlyBranch;
1648 case CSSValueCjkHeavenlyStem:
1649 return EListStyleType::CjkHeavenlyStem;
1650 case CSSValueCjkIdeographic:
1651 return EListStyleType::CJKIdeographic;
1652 case CSSValueDecimalLeadingZero:
1653 return EListStyleType::DecimalLeadingZero;
1654 case CSSValueDecimal:
1655 return EListStyleType::DecimalListStyle;
1656 case CSSValueDevanagari:
1657 return EListStyleType::Devanagari;
1658 case CSSValueDisc:
1659 return EListStyleType::Disc;
1660 case CSSValueEthiopicHalehame:
1661 return EListStyleType::EthiopicHalehame;
1662 case CSSValueEthiopicHalehameAm:
1663 return EListStyleType::EthiopicHalehameAm;
1664 case CSSValueEthiopicHalehameTiEt:
1665 return EListStyleType::EthiopicHalehameTiEt;
1666 case CSSValueEthiopicHalehameTiEr:
1667 return EListStyleType::EthiopicHalehameTiEr;
1668 case CSSValueGeorgian:
1669 return EListStyleType::Georgian;
1670 case CSSValueGujarati:
1671 return EListStyleType::Gujarati;
1672 case CSSValueGurmukhi:
1673 return EListStyleType::Gurmukhi;
1674 case CSSValueHangul:
1675 return EListStyleType::Hangul;
1676 case CSSValueHangulConsonant:
1677 return EListStyleType::HangulConsonant;
1678 case CSSValueKoreanHangulFormal:
1679 return EListStyleType::KoreanHangulFormal;
1680 case CSSValueKoreanHanjaFormal:
1681 return EListStyleType::KoreanHanjaFormal;
1682 case CSSValueKoreanHanjaInformal:
1683 return EListStyleType::KoreanHanjaInformal;
1684 case CSSValueHebrew:
1685 return EListStyleType::Hebrew;
1686 case CSSValueHiragana:
1687 return EListStyleType::Hiragana;
1688 case CSSValueHiraganaIroha:
1689 return EListStyleType::HiraganaIroha;
1690 case CSSValueKannada:
1691 return EListStyleType::Kannada;
1692 case CSSValueKatakana:
1693 return EListStyleType::Katakana;
1694 case CSSValueKatakanaIroha:
1695 return EListStyleType::KatakanaIroha;
1696 case CSSValueKhmer:
1697 return EListStyleType::Khmer;
1698 case CSSValueLao:
1699 return EListStyleType::Lao;
1700 case CSSValueLowerAlpha:
1701 return EListStyleType::LowerAlpha;
1702 case CSSValueLowerArmenian:
1703 return EListStyleType::LowerArmenian;
1704 case CSSValueLowerGreek:
1705 return EListStyleType::LowerGreek;
1706 case CSSValueLowerLatin:
1707 return EListStyleType::LowerLatin;
1708 case CSSValueLowerRoman:
1709 return EListStyleType::LowerRoman;
1710 case CSSValueMalayalam:
1711 return EListStyleType::Malayalam;
1712 case CSSValueMongolian:
1713 return EListStyleType::Mongolian;
1714 case CSSValueMyanmar:
1715 return EListStyleType::Myanmar;
1716 case CSSValueOriya:
1717 return EListStyleType::Oriya;
1718 case CSSValuePersian:
1719 return EListStyleType::Persian;
1720 case CSSValueSimpChineseFormal:
1721 return EListStyleType::SimpChineseFormal;
1722 case CSSValueSimpChineseInformal:
1723 return EListStyleType::SimpChineseInformal;
1724 case CSSValueSquare:
1725 return EListStyleType::Square;
1726 case CSSValueTelugu:
1727 return EListStyleType::Telugu;
1728 case CSSValueThai:
1729 return EListStyleType::Thai;
1730 case CSSValueTibetan:
1731 return EListStyleType::Tibetan;
1732 case CSSValueTradChineseFormal:
1733 return EListStyleType::TradChineseFormal;
1734 case CSSValueTradChineseInformal:
1735 return EListStyleType::TradChineseInformal;
1736 case CSSValueUpperAlpha:
1737 return EListStyleType::UpperAlpha;
1738 case CSSValueUpperArmenian:
1739 return EListStyleType::UpperArmenian;
1740 case CSSValueUpperLatin:
1741 return EListStyleType::UpperLatin;
1742 case CSSValueUpperRoman:
1743 return EListStyleType::UpperRoman;
1744 case CSSValueUrdu:
1745 return EListStyleType::Urdu;
1636 default: 1746 default:
1637 return static_cast<EListStyleType>(m_valueID - CSSValueDisc); 1747 break;
1638 } 1748 }
1749
1750 NOTREACHED();
1751 return EListStyleType::NoneListStyle;
1639 } 1752 }
1640 1753
1641 template <> 1754 template <>
1642 inline CSSIdentifierValue::CSSIdentifierValue(EMarginCollapse e) 1755 inline CSSIdentifierValue::CSSIdentifierValue(EMarginCollapse e)
1643 : CSSValue(IdentifierClass) { 1756 : CSSValue(IdentifierClass) {
1644 switch (e) { 1757 switch (e) {
1645 case MarginCollapseCollapse: 1758 case MarginCollapseCollapse:
1646 m_valueID = CSSValueCollapse; 1759 m_valueID = CSSValueCollapse;
1647 break; 1760 break;
1648 case MarginCollapseSeparate: 1761 case MarginCollapseSeparate:
(...skipping 2901 matching lines...) Expand 10 before | Expand all | Expand 10 after
4550 default: 4663 default:
4551 break; 4664 break;
4552 } 4665 }
4553 ASSERT_NOT_REACHED(); 4666 ASSERT_NOT_REACHED();
4554 return ContainsNone; 4667 return ContainsNone;
4555 } 4668 }
4556 4669
4557 } // namespace blink 4670 } // namespace blink
4558 4671
4559 #endif 4672 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698