Source/core/dom/CharacterData.cpp - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/CharacterData.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/CharacterData.cpp

diff --git a/Source/core/dom/CharacterData.cpp b/Source/core/dom/CharacterData.cpp

index f93c0f7b9cae651e6261ded70792198d82fa583d..15435c47f488f82a28b66aa5df5b2c5d2d190cf3 100644

--- a/Source/core/dom/CharacterData.cpp

+++ b/Source/core/dom/CharacterData.cpp

@@ -189,7 +189,7 @@ void CharacterData::setDataAndUpdate(const String& newData, unsigned offsetOfRep

void CharacterData::didModifyData(const String& oldData)

{

- if (OwnPtr<MutationObserverInterestGroup> mutationRecipients = MutationObserverInterestGroup::createForCharacterDataMutation(*this))

+ if (OwnPtrWillBeRawPtr<MutationObserverInterestGroup> mutationRecipients = MutationObserverInterestGroup::createForCharacterDataMutation(*this))

mutationRecipients->enqueueMutationRecord(MutationRecord::createCharacterData(this, oldData));

if (parentNode())

« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/dom/ChildListMutationScope.h » ('j') | Source/core/dom/NodeRareData.h » ('J')