Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 23665003: DevTools: Revoke undo/redo due to inconsistent behavior determining the source of storage mutation (Closed)

Created:
7 years, 3 months ago by vivekg_samsung
Modified:
7 years, 3 months ago
Reviewers:
pfeldman, vivekg__
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Revoke undo/redo due to inconsistent behavior determining the source of storage mutation Reverting this as discussed in CL https://codereview.chromium.org/23480006 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156962

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -686 lines) Patch
D LayoutTests/inspector/storage-panel-dom-storage-undo-redo.html View 1 chunk +0 lines, -339 lines 0 comments Download
D LayoutTests/inspector/storage-panel-dom-storage-undo-redo-expected.txt View 1 chunk +0 lines, -74 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/devtools/front_end/DOMStorage.js View 1 4 chunks +2 lines, -217 lines 0 comments Download
M Source/devtools/front_end/DOMStorageItemsView.js View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/devtools/front_end/ResourcesPanel.js View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
vivekg_samsung
PTAL.
7 years, 3 months ago (2013-08-29 07:04:02 UTC) #1
vivekg__
7 years, 3 months ago (2013-08-29 07:05:06 UTC) #2
pfeldman
lgtm. thanks for understanding - it is not always easy to revert things, but I ...
7 years, 3 months ago (2013-08-29 11:31:41 UTC) #3
vivekg__
On 2013/08/29 11:31:41, pfeldman wrote: > lgtm. thanks for understanding - it is not always ...
7 years, 3 months ago (2013-08-29 11:43:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23665003/1
7 years, 3 months ago (2013-08-29 11:44:30 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3517
7 years, 3 months ago (2013-08-29 13:09:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23665003/1
7 years, 3 months ago (2013-08-29 14:04:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3524
7 years, 3 months ago (2013-08-29 15:28:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23665003/1
7 years, 3 months ago (2013-08-29 15:28:55 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3531
7 years, 3 months ago (2013-08-29 16:49:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23665003/1
7 years, 3 months ago (2013-08-30 01:05:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23665003/36001
7 years, 3 months ago (2013-08-30 04:32:23 UTC) #12
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 06:10:39 UTC) #13
Message was sent while issue was closed.
Change committed as 156962

Powered by Google App Engine
This is Rietveld 408576698