Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: Source/core/inspector/InspectorDOMStorageAgent.cpp

Issue 23665003: DevTools: Revoke undo/redo due to inconsistent behavior determining the source of storage mutation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMStorageAgent.h ('k') | Source/devtools/front_end/DOMStorage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMStorageAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMStorageAgent.cpp b/Source/core/inspector/InspectorDOMStorageAgent.cpp
index 4b2a118bd66dc516e4d8a74293c9eeee5bb6f20e..4420d1b901672293845e4b0901a9303cfd8fee93 100644
--- a/Source/core/inspector/InspectorDOMStorageAgent.cpp
+++ b/Source/core/inspector/InspectorDOMStorageAgent.cpp
@@ -108,22 +108,6 @@ void InspectorDOMStorageAgent::disable(ErrorString*)
m_state->setBoolean(DOMStorageAgentState::domStorageAgentEnabled, false);
}
-void InspectorDOMStorageAgent::getValue(ErrorString* errorString, const RefPtr<JSONObject>& storageId, const String& key, TypeBuilder::OptOutput<WTF::String>* value)
-{
- Frame* frame;
- OwnPtr<StorageArea> storageArea = findStorageArea(errorString, storageId, frame);
- if (!storageArea)
- return;
-
- TrackExceptionState es;
- bool keyPresent = storageArea->contains(key, es, frame);
- if (hadException(es, errorString) || !keyPresent)
- return;
-
- *value = storageArea->getItem(key, es, frame);
- hadException(es, errorString);
-}
-
void InspectorDOMStorageAgent::getDOMStorageItems(ErrorString* errorString, const RefPtr<JSONObject>& storageId, RefPtr<TypeBuilder::Array<TypeBuilder::Array<String> > >& items)
{
Frame* frame;
« no previous file with comments | « Source/core/inspector/InspectorDOMStorageAgent.h ('k') | Source/devtools/front_end/DOMStorage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698