Source/core/inspector/InspectorDOMStorageAgent.h - Issue 23665003: DevTools: Revoke undo/redo due to inconsistent behavior determining the source of storage mutation

Side by Side Diff: Source/core/inspector/InspectorDOMStorageAgent.h

Issue 23665003: DevTools: Revoke undo/redo due to inconsistent behavior determining the source of storage mutation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/storage-panel-dom-storage-undo-redo-expected.txt ('k') | Source/core/inspector/InspectorDOMStorageAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 return adoptPtr(new InspectorDOMStorageAgent(instrumentingAgents, pageAg ent, state));	53 return adoptPtr(new InspectorDOMStorageAgent(instrumentingAgents, pageAg ent, state));

54 }	54 }

55 ~InspectorDOMStorageAgent();	55 ~InspectorDOMStorageAgent();

56	56

57 virtual void setFrontend(InspectorFrontend*);	57 virtual void setFrontend(InspectorFrontend*);

58 virtual void clearFrontend();	58 virtual void clearFrontend();

59	59

60 // Called from the front-end.	60 // Called from the front-end.

61 virtual void enable(ErrorString*);	61 virtual void enable(ErrorString*);

62 virtual void disable(ErrorString*);	62 virtual void disable(ErrorString*);

63 virtual void getValue(ErrorString, const RefPtr<JSONObject>& storageId, con st String& key, TypeBuilder::OptOutput<WTF::String> value);

64 virtual void getDOMStorageItems(ErrorString*, const RefPtr<JSONObject>& stor ageId, RefPtr<TypeBuilder::Array<TypeBuilder::Array<String> > >& items);	63 virtual void getDOMStorageItems(ErrorString*, const RefPtr<JSONObject>& stor ageId, RefPtr<TypeBuilder::Array<TypeBuilder::Array<String> > >& items);

65 virtual void setDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& stora geId, const String& key, const String& value);	64 virtual void setDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& stora geId, const String& key, const String& value);

66 virtual void removeDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& st orageId, const String& key);	65 virtual void removeDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& st orageId, const String& key);

67	66

68 // Called from the injected script.	67 // Called from the injected script.

69 String storageId(Storage*);	68 String storageId(Storage*);

70 PassRefPtr<TypeBuilder::DOMStorage::StorageId> storageId(SecurityOrigin*, bo ol isLocalStorage);	69 PassRefPtr<TypeBuilder::DOMStorage::StorageId> storageId(SecurityOrigin*, bo ol isLocalStorage);

71	70

72 // Called from InspectorInstrumentation	71 // Called from InspectorInstrumentation

73 void didDispatchDOMStorageEvent(const String& key, const String& oldValue, c onst String& newValue, StorageType, SecurityOrigin*);	72 void didDispatchDOMStorageEvent(const String& key, const String& oldValue, c onst String& newValue, StorageType, SecurityOrigin*);

74	73

75 private:	74 private:

76	75

77 InspectorDOMStorageAgent(InstrumentingAgents, InspectorPageAgent, Inspecto rCompositeState*);	76 InspectorDOMStorageAgent(InstrumentingAgents, InspectorPageAgent, Inspecto rCompositeState*);

78	77

79 bool isEnabled() const;	78 bool isEnabled() const;

80 PassOwnPtr<StorageArea> findStorageArea(ErrorString, const RefPtr<JSONObjec t>&, Frame&);	79 PassOwnPtr<StorageArea> findStorageArea(ErrorString, const RefPtr<JSONObjec t>&, Frame&);

81	80

82 InspectorPageAgent* m_pageAgent;	81 InspectorPageAgent* m_pageAgent;

83 InspectorFrontend* m_frontend;	82 InspectorFrontend* m_frontend;

84 };	83 };

85	84

86 } // namespace WebCore	85 } // namespace WebCore

87	86

88 #endif // !defined(InspectorDOMStorageAgent_h)	87 #endif // !defined(InspectorDOMStorageAgent_h)

OLD	NEW