Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2366393002: [heap] Reland Concurrently free empty typed slot set chunks. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland Concurrently free empty typed slot set chunks. BUG=chromium:648568 Committed: https://crrev.com/b1b47aaea73e744f6f4a3709a90f08397399f71a Cr-Commit-Position: refs/heads/master@{#39735}

Patch Set 1 #

Patch Set 2 : Do not free typed old-new sets on main thread. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -33 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/remembered-set.h View 1 3 chunks +8 lines, -7 lines 0 comments Download
M src/heap/remembered-set.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/slot-set.h View 6 chunks +37 lines, -1 line 0 comments Download
M src/heap/spaces.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Hannes Payer (out of office)
4 years, 2 months ago (2016-09-26 14:33:34 UTC) #2
ulan
lgtm
4 years, 2 months ago (2016-09-26 15:49:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366393002/20001
4 years, 2 months ago (2016-09-26 15:51:30 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 15:54:07 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 15:54:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1b47aaea73e744f6f4a3709a90f08397399f71a
Cr-Commit-Position: refs/heads/master@{#39735}

Powered by Google App Engine
This is Rietveld 408576698