Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2366363002: Move remaining functionality from ClassWorld to ClosedWorld (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move remaining functionality from ClassWorld to ClosedWorld ... and rename ClassWorld to World. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/a1cd69561284cda5903672ed0646b09653706a3e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -228 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 8 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/types/container_type_mask.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/dictionary_type_mask.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 2 chunks +32 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 3 chunks +23 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/types/value_type_mask.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 3 chunks +5 lines, -6 lines 1 comment Download
M pkg/compiler/lib/src/universe/universe.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 8 chunks +31 lines, -44 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2366363002/diff/1/pkg/compiler/lib/src/universe/selector.dart File pkg/compiler/lib/src/universe/selector.dart (left): https://codereview.chromium.org/2366363002/diff/1/pkg/compiler/lib/src/universe/selector.dart#oldcode233 pkg/compiler/lib/src/universe/selector.dart:233: if (target.isForeign(element)) return true; This wasn't needed. In the ...
4 years, 2 months ago (2016-09-26 14:04:42 UTC) #2
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-09-26 23:24:06 UTC) #3
Johnni Winther
4 years, 2 months ago (2016-09-27 08:23:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a1cd69561284cda5903672ed0646b09653706a3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698