Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: pkg/compiler/lib/src/universe/selector.dart

Issue 2366363002: Move remaining functionality from ClassWorld to ClosedWorld (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/universe/function_set.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/universe/selector.dart
diff --git a/pkg/compiler/lib/src/universe/selector.dart b/pkg/compiler/lib/src/universe/selector.dart
index 14d8b3adaf90b734fd3789e4e9fb2ed0f592a600..39937fbddbc499d58f78fd55c34e30ac18d4be04 100644
--- a/pkg/compiler/lib/src/universe/selector.dart
+++ b/pkg/compiler/lib/src/universe/selector.dart
@@ -217,12 +217,12 @@ class Selector {
return kind;
}
- bool appliesUnnamed(Element element, Target target) {
+ bool appliesUnnamed(Element element) {
assert(sameNameHack(element));
- return appliesUntyped(element, target);
+ return appliesUntyped(element);
}
- bool appliesUntyped(Element element, Target target) {
+ bool appliesUntyped(Element element) {
assert(sameNameHack(element));
if (Elements.isUnresolved(element)) return false;
if (memberName.isPrivate && memberName.library != element.library) {
@@ -230,7 +230,6 @@ class Selector {
// `memberName != element.memberName`.
return false;
}
- if (target.isForeign(element)) return true;
Johnni Winther 2016/09/26 14:04:42 This wasn't needed. In the very old days selectors
if (element.isSetter) return isSetter;
if (element.isGetter) return isGetter || isCall;
if (element.isField) {
@@ -253,9 +252,9 @@ class Selector {
return element.isConstructor || name == element.name;
}
- bool applies(Element element, Target target) {
+ bool applies(Element element) {
if (!sameNameHack(element)) return false;
- return appliesUnnamed(element, target);
+ return appliesUnnamed(element);
}
bool match(SelectorKind kind, Name memberName, CallStructure callStructure) {
« no previous file with comments | « pkg/compiler/lib/src/universe/function_set.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698