Move remaining functionality from ClassWorld to ClosedWorld

pkg/compiler/lib/src/universe/selector.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.selector;
 
 import '../common.dart';
 import '../common/names.dart' show Names;
 import '../elements/elements.dart'
     show
@@ skipping 199 matching lines @@
     const int SETTER = 2;
     int kind = METHOD;
     if (isGetter) {
       kind = GETTER;
     } else if (isSetter) {
       kind = SETTER;
     }
     return kind;
   }
 
-  bool appliesUnnamed(Element element, Target target) {
+  bool appliesUnnamed(Element element) {
     assert(sameNameHack(element));
-    return appliesUntyped(element, target);
+    return appliesUntyped(element);
   }
 
-  bool appliesUntyped(Element element, Target target) {
+  bool appliesUntyped(Element element) {
     assert(sameNameHack(element));
     if (Elements.isUnresolved(element)) return false;
     if (memberName.isPrivate && memberName.library != element.library) {
       // TODO(johnniwinther): Maybe this should be
       // `memberName != element.memberName`.
       return false;
     }
-    if (target.isForeign(element)) return true;

[Johnni Winther, 2016/09/26 14:04:42]

This wasn't needed. In the very old days selectors we're also (incorrectly) used
for static uses and this was a remedy from it.

     if (element.isSetter) return isSetter;
     if (element.isGetter) return isGetter || isCall;
     if (element.isField) {
       return isSetter
           ? !element.isFinal && !element.isConst
           : isGetter || isCall;
     }
     if (isGetter) return true;
     if (isSetter) return false;
     return signatureApplies(element);
   }
 
   bool signatureApplies(FunctionElement function) {
     if (Elements.isUnresolved(function)) return false;
     return callStructure.signatureApplies(function.functionSignature);
   }
 
   bool sameNameHack(Element element) {
     // TODO(ngeoffray): Remove workaround checks.
     return element.isConstructor || name == element.name;
   }
 
-  bool applies(Element element, Target target) {
+  bool applies(Element element) {
     if (!sameNameHack(element)) return false;
-    return appliesUnnamed(element, target);
+    return appliesUnnamed(element);
   }
 
   bool match(SelectorKind kind, Name memberName, CallStructure callStructure) {
     return this.kind == kind &&
         this.memberName == memberName &&
         this.callStructure.match(callStructure);
   }
 
   static int computeHashCode(
       SelectorKind kind, Name name, CallStructure callStructure) {
     // Add bits from name and kind.
     int hash = Hashing.mixHashCodeBits(name.hashCode, kind.hashCode);
     // Add bits from the call structure.
     return Hashing.mixHashCodeBits(hash, callStructure.hashCode);
   }
 
   String toString() {
     return 'Selector($kind, $name, ${callStructure.structureToString()})';
   }
 
   Selector toCallSelector() => new Selector.callClosureFrom(this);
 }