Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2366263004: Handle fields with initializers in kernel_impact (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle fields with initializers in kernel_impact - and use Feature.TYPE_VARIABLE_BOUNDS_CHECK only for new-expressions. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/93d7c65cc998699e7f22de3edacc53f67f1963a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 4 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-09-27 10:23:58 UTC) #2
Johnni Winther
ping
4 years, 2 months ago (2016-09-28 08:27:09 UTC) #3
Johnni Winther
PING
4 years, 2 months ago (2016-09-29 07:19:14 UTC) #4
Harry Terkelsen
lgtm lgtm sorry for missing this in my inbox!
4 years, 2 months ago (2016-09-29 19:36:24 UTC) #5
Johnni Winther
4 years, 2 months ago (2016-09-30 07:51:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93d7c65cc998699e7f22de3edacc53f67f1963a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698