pkg/compiler/lib/src/ssa/kernel_impact.dart - Issue 2366263004: Handle fields with initializers in kernel_impact

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2366263004: Handle fields with initializers in kernel_impact (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/kernel_impact.dart

diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart

index a2f9279ab3d46d48e7c489d3b5ad8d090dca1f52..c1f53ca930d876de0c02be960e284e3a72f59fcf 100644

--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart

+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart

@@ -83,6 +83,9 @@ class KernelImpactBuilder extends ir.Visitor {

checkType(field.type);

if (field.initializer != null) {

visitNode(field.initializer);

+ if (!field.isConst) {

+ impactBuilder.registerFeature(Feature.LAZY_FIELD);

+ }

} else {

impactBuilder.registerFeature(Feature.FIELD_WITHOUT_INITIALIZER);

}