Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2366263004: Handle fields with initializers in kernel_impact (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 390b16194bcca03073d70e3e03a0409620b0bc10..a677083acc9c39edb01c70a08aa07b2130d3097a 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3665,6 +3665,9 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
// TODO(johnniwinther): Handle this (potentially) erroneous case.
isValidAsConstant = false;
}
+ if (type.typeArguments.any((DartType type) => !type.isDynamic)) {
+ registry.registerFeature(Feature.TYPE_VARIABLE_BOUNDS_CHECK);
+ }
redirectionTarget.computeType(resolution);
FunctionSignature targetSignature = redirectionTarget.functionSignature;
@@ -3887,6 +3890,10 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
// TODO(johniwinther): Avoid registration of `type` in face of redirecting
// factory constructors.
registry.registerTypeUse(new TypeUse.instantiation(type));
+ InterfaceType interfaceType = type;
+ if (interfaceType.typeArguments.any((DartType type) => !type.isDynamic)) {
+ registry.registerFeature(Feature.TYPE_VARIABLE_BOUNDS_CHECK);
+ }
}
ResolutionResult resolutionResult = const NoneResult();
« no previous file with comments | « no previous file | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698