Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
index 3bc57bcaf19d82626d2556e921be2925ed8e9b4b..775d3b98818ac5038ea6358d1aeefa9426d67f26 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
@@ -179,7 +179,7 @@ TEST_F(ScriptPromiseResolverTest, stop) {
Function::createFunction(getScriptState(), &onRejected));
}
- getExecutionContext()->stopActiveDOMObjects();
+ getExecutionContext()->notifyContextDestroyed();
{
ScriptState::Scope scope(getScriptState());
EXPECT_TRUE(resolver->promise().isEmpty());
@@ -263,7 +263,7 @@ TEST_F(ScriptPromiseResolverTest, keepAliveUntilStopped) {
BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
EXPECT_TRUE(ScriptPromiseResolverKeepAlive::isAlive());
- getExecutionContext()->stopActiveDOMObjects();
+ getExecutionContext()->notifyContextDestroyed();
ThreadState::current()->collectGarbage(
BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
EXPECT_FALSE(ScriptPromiseResolverKeepAlive::isAlive());
@@ -287,7 +287,7 @@ TEST_F(ScriptPromiseResolverTest, suspend) {
BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
EXPECT_TRUE(ScriptPromiseResolverKeepAlive::isAlive());
- getExecutionContext()->stopActiveDOMObjects();
+ getExecutionContext()->notifyContextDestroyed();
ThreadState::current()->collectGarbage(
BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
EXPECT_FALSE(ScriptPromiseResolverKeepAlive::isAlive());

Powered by Google App Engine
This is Rietveld 408576698