Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
index 0d0b08c7ec2b9f9077adf6e3b742f506d47af537..f03dfb3508ee3a50d82574df321b0017c5fc9281 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
@@ -552,12 +552,13 @@ void WorkerThread::prepareForShutdownOnWorkerThread() {
m_inspectorTaskRunner->kill();
workerReportingProxy().willDestroyWorkerGlobalScope();
InspectorInstrumentation::allAsyncTasksCanceled(globalScope());
+
+ globalScope()->notifyContextDestroyed();
haraken 2016/10/04 14:59:58 This is a just-in-case change. I moved notifyConte
globalScope()->dispose();
if (m_workerInspectorController) {
m_workerInspectorController->dispose();
m_workerInspectorController.clear();
}
- globalScope()->notifyContextDestroyed();
m_consoleMessageStorage.clear();
workerBackingThread().backingThread().removeTaskObserver(
m_microtaskRunner.get());

Powered by Google App Engine
This is Rietveld 408576698