third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h - Issue 2366253002: Remove ActiveDOMObject::stop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)

Patch Set: temp Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

index 130ced8b999e0a4bda6ec8e4d5b1a3747cb84d04..a07e16d4494ed318ad780380a74845134ad4caf6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

@@ -88,7 +88,7 @@ class CORE_EXPORT ScriptPromiseResolver

// ActiveDOMObject implementation.

void suspend() override;

void resume() override;

- void stop() override { detach(); }

+ void contextDestroyed() override { detach(); }

// Calling this function makes the resolver release its internal resources.

// That means the associated promise will never be resolved or rejected