Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 23657003: Move url_open with dependencies to utils.net module. (Closed)

Created:
7 years, 3 months ago by Vadim Sh.
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Move url_open with dependencies to utils.net module. Also add back run_isolated.zip support to swarming.py. BUG=277130 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=220027

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -979 lines) Patch
M isolateserver_archive.py View 3 chunks +7 lines, -6 lines 0 comments Download
M run_isolated.py View 5 chunks +3 lines, -482 lines 1 comment Download
M swarming.py View 10 chunks +29 lines, -37 lines 1 comment Download
M tests/isolateserver_archive_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + tests/net_test.py View 11 chunks +28 lines, -163 lines 0 comments Download
M tests/run_isolated_test.py View 5 chunks +3 lines, -264 lines 0 comments Download
M tests/swarming_test.py View 10 chunks +8 lines, -20 lines 0 comments Download
M tests/url_open_timeout_test.py View 4 chunks +6 lines, -6 lines 0 comments Download
A utils/net.py View 1 chunk +507 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vadim Sh.
Please take a look. It's a successor of https://codereview.chromium.org/23431002/ with a clean diff. Rebasing on ...
7 years, 3 months ago (2013-08-28 04:22:05 UTC) #1
Vadim Sh.
Also this CL should fix canary. All test pass and I explicitly verified that run_example_swarm.py ...
7 years, 3 months ago (2013-08-28 04:56:57 UTC) #2
M-A Ruel
lgtm, thanks for fixing. I noted optional nits you can do as a follow up ...
7 years, 3 months ago (2013-08-28 15:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/23657003/1
7 years, 3 months ago (2013-08-28 15:02:04 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 15:03:47 UTC) #5
Message was sent while issue was closed.
Change committed as 220027

Powered by Google App Engine
This is Rietveld 408576698