Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 23431002: [Abandoned] Move url_open with dependencies to utils.net module. (Closed)

Created:
7 years, 3 months ago by Vadim Sh.
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Move url_open with dependencies to utils.net module. BUG=277130 DO NOT SUBMIT Abandoned in favor of https://codereview.chromium.org/23657003/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -944 lines) Patch
M isolateserver_archive.py View 3 chunks +7 lines, -6 lines 0 comments Download
M run_isolated.py View 5 chunks +3 lines, -482 lines 0 comments Download
M swarm_get_results.py View 4 chunks +7 lines, -9 lines 0 comments Download
M swarm_trigger_step.py View 6 chunks +7 lines, -6 lines 0 comments Download
M tests/isolateserver_archive_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + tests/net_test.py View 11 chunks +28 lines, -163 lines 0 comments Download
M tests/run_isolated_test.py View 5 chunks +3 lines, -264 lines 0 comments Download
M tests/swarm_get_results_test.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/swarm_trigger_step_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/url_open_timeout_test.py View 4 chunks +6 lines, -6 lines 0 comments Download
A utils/net.py View 1 chunk +507 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vadim Sh.
Hello, Another freakin' huge code review. There's almost no code changes. I added net.HttpResponse.get_fake_response and ...
7 years, 3 months ago (2013-08-26 18:46:34 UTC) #1
M-A Ruel
On 2013/08/26 18:46:34, Vadim Sh. wrote: > Hello, > > Another freakin' huge code review. ...
7 years, 3 months ago (2013-08-26 18:50:40 UTC) #2
Vadim Sh.
On 2013/08/26 18:50:40, M-A Ruel wrote: > On 2013/08/26 18:46:34, Vadim Sh. wrote: > > ...
7 years, 3 months ago (2013-08-26 18:59:49 UTC) #3
M-A Ruel
7 years, 3 months ago (2013-08-27 21:56:21 UTC) #4
On 2013/08/26 18:59:49, Vadim Sh. wrote:
> On 2013/08/26 18:50:40, M-A Ruel wrote:
> > Do you mind waiting for https://codereview.chromium.org/22980008 to get in
> > first?
> 
> No problem.
> 
> Rebasing sucks, heh? :)

You can rebase now.

Powered by Google App Engine
This is Rietveld 408576698