Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2365603002: [heap] Reland Concurrently free empty typed slot set chunks. (Closed)

Created:
4 years, 3 months ago by Hannes Payer (out of office)
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland Concurrently free empty typed slot set chunks. BUG=chromium:648568 Committed: https://crrev.com/ec3835751d678c0b4a3fda47d11ffa107cd27e23 Cr-Commit-Position: refs/heads/master@{#39630}

Patch Set 1 #

Patch Set 2 : make typed slot set field atomic #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -31 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/remembered-set.h View 2 chunks +8 lines, -5 lines 0 comments Download
M src/heap/remembered-set.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/slot-set.h View 6 chunks +37 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/heap/spaces.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/2365603002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2365603002/diff/20001/src/heap/spaces.h#newcode659 src/heap/spaces.h:659: base::AtomicValue<TypedSlotSet*> typed_old_to_new_slots_; Let's play safe here an make that ...
4 years, 3 months ago (2016-09-22 12:49:23 UTC) #2
ulan
lgtm
4 years, 3 months ago (2016-09-22 12:55:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365603002/20001
4 years, 3 months ago (2016-09-22 14:28:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 14:32:32 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec3835751d678c0b4a3fda47d11ffa107cd27e23 Cr-Commit-Position: refs/heads/master@{#39630}
4 years, 3 months ago (2016-09-22 14:32:53 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-09-22 15:14:31 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2364603002/ by machenbach@chromium.org.

The reason for reverting is: Leaks and TSAN:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/15441
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11867.

Powered by Google App Engine
This is Rietveld 408576698