src/heap/remembered-set.cc - Issue 2365603002: [heap] Reland Concurrently free empty typed slot set chunks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/remembered-set.cc

Issue 2365603002: [heap] Reland Concurrently free empty typed slot set chunks. (Closed)

Patch Set: make typed slot set field atomic Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/remembered-set.cc

diff --git a/src/heap/remembered-set.cc b/src/heap/remembered-set.cc

index 6575d55d525e674df0fbb73a43db77f81b615a82..467f72500881643d87ed7e12e8d519995959b31a 100644

--- a/src/heap/remembered-set.cc

+++ b/src/heap/remembered-set.cc

@@ -36,7 +36,8 @@ void RememberedSet<direction>::ClearInvalidSlots(Heap* heap) {

} else {

return REMOVE_SLOT;

}

- });

+ },

+ TypedSlotSet::PREFREE_EMPTY_CHUNKS);

}

for (MemoryChunk* chunk : *heap->map_space()) {