chrome/browser/ssl/chrome_expect_ct_reporter.cc - Issue 2365353004: Add Content-Type header to net::ReportSender reports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2365353004: Add Content-Type header to net::ReportSender reports (Closed)

Patch Set: make content type a required parameter to Send() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc

diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc

index 297ecdc138e3e3235933c15e50e2498d0cb4c027..f0b81f8d31dc02791348445321a4cdfeffca395e 100644

--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc

+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc

@@ -176,5 +176,5 @@ void ChromeExpectCTReporter::OnExpectCTFailed(

UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true);

- report_sender_->Send(report_uri, serialized_report);

+ report_sender_->Send(report_uri, "application/json", serialized_report);

eroman 2016/09/26 21:14:07 What is your take on using "application/json; char

estark 2016/09/26 23:26:10 Sure, that seems reasonable. Done.

}