chrome/browser/ssl/chrome_expect_ct_reporter.cc - Issue 2365353004: Add Content-Type header to net::ReportSender reports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2365353004: Add Content-Type header to net::ReportSender reports (Closed)

Patch Set: make content type a required parameter to Send() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter_unittest.cc ('k') | chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc » ('j') | net/http/transport_security_state.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ssl/chrome_expect_ct_reporter.h"	5 #include "chrome/browser/ssl/chrome_expect_ct_reporter.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/base64.h"	9 #include "base/base64.h"

10 #include "base/command_line.h"	10 #include "base/command_line.h"

(...skipping 158 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
169 report.Set("valid-scts", std::move(valid_scts));	169 report.Set("valid-scts", std::move(valid_scts));

170	170

171 std::string serialized_report;	171 std::string serialized_report;

172 if (!base::JSONWriter::Write(report, &serialized_report)) {	172 if (!base::JSONWriter::Write(report, &serialized_report)) {

173 LOG(ERROR) << "Failed to serialize Expect CT report";	173 LOG(ERROR) << "Failed to serialize Expect CT report";

174 return;	174 return;

175 }	175 }

176	176

177 UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true);	177 UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true);

178	178

179 report_sender_->Send(report_uri, serialized_report);	179 report_sender_->Send(report_uri, "application/json", serialized_report);
	eroman 2016/09/26 21:14:07 What is your take on using "application/json; char What is your take on using "application/json; charset=utf-8" ? In practice I think application/json is going to be interpreted as UTF-8, but if the goal here is fixing a server-side compatibility issue, it might be better to be explicit. estark 2016/09/26 23:26:10 Sure, that seems reasonable. Done. Show quoted text On 2016/09/26 21:14:07, eroman wrote: > What is your take on using "application/json; charset=utf-8" ? > > In practice I think application/json is going to be interpreted as UTF-8, but if > the goal here is fixing a server-side compatibility issue, it might be better to > be explicit. Sure, that seems reasonable. Done.
180 }	180 }

OLD	NEW