Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: net/http/transport_security_state.h

Issue 2365353004: Add Content-Type header to net::ReportSender reports (Closed)
Patch Set: make content type a required parameter to Send() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index 14ddfc00df1703cb32c3ab3b334a5647f9c44d92..eac5958bbb8e89ca9762245c35046d0b523950ef 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -252,8 +252,11 @@ class NET_EXPORT TransportSecurityState
// An interface for asynchronously sending HPKP violation reports.
class NET_EXPORT ReportSenderInterface {
public:
- // Sends the given serialized |report| to |report_uri|.
- virtual void Send(const GURL& report_uri, const std::string& report) = 0;
+ // Sends the given serialized |report| to |report_uri| with Content-Type
+ // header as specified in |content_type|.
eroman 2016/09/26 21:14:07 Can you add a note that content-type should be non
estark 2016/09/26 23:26:10 Done.
+ virtual void Send(const GURL& report_uri,
+ const std::string& content_type,
eroman 2016/09/26 21:14:07 What about base::StringPiece for these parameters?
estark 2016/09/26 23:26:10 Done.
+ const std::string& report) = 0;
// Sets a callback to be called when report sending fails.
virtual void SetErrorCallback(

Powered by Google App Engine
This is Rietveld 408576698