Added isComputedStyle::isDisplayTableType() and made it static

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 2449 matching lines @@
     void setVisitedLinkBorderTopColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBorderTopColor, v); }
     void setVisitedLinkOutlineColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkOutlineColor, v); }
     void setVisitedLinkColumnRuleColor(const StyleColor& v) { SET_NESTED_VAR(m_rareNonInheritedData, m_multiCol, m_visitedLinkColumnRuleColor, v); }
     void setVisitedLinkTextDecorationColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkTextDecorationColor, v); }
     void setVisitedLinkTextEmphasisColor(const StyleColor& v) { SET_VAR_WITH_SETTER(m_rareInheritedData, visitedLinkTextEmphasisColor, setVisitedLinkTextEmphasisColor, v); }
     void setVisitedLinkTextFillColor(const StyleColor& v) { SET_VAR_WITH_SETTER(m_rareInheritedData, visitedLinkTextFillColor, setVisitedLinkTextFillColor, v); }
     void setVisitedLinkTextStrokeColor(const StyleColor& v) { SET_VAR_WITH_SETTER(m_rareInheritedData, visitedLinkTextStrokeColor, setVisitedLinkTextStrokeColor, v); }
 
     void inheritUnicodeBidiFrom(const ComputedStyle& parent) { m_nonInheritedData.m_unicodeBidi = parent.m_nonInheritedData.m_unicodeBidi; }
 
-    bool isDisplayFlexibleBox(EDisplay display) const
+    static bool isDisplayFlexibleBox(EDisplay display)
     {
         return display == FLEX || display == INLINE_FLEX;
     }
 
-    bool isDisplayGridBox(EDisplay display) const
+    static bool isDisplayGridBox(EDisplay display)
     {
         return display == GRID || display == INLINE_GRID;
     }
 
-    bool isDisplayReplacedType(EDisplay display) const
+    static bool isDisplayReplacedType(EDisplay display)
     {
         return display == INLINE_BLOCK || display == INLINE_BOX || display == INLINE_FLEX
             || display == INLINE_TABLE || display == INLINE_GRID;
     }
 
-    bool isDisplayInlineType(EDisplay display) const
+    static bool isDisplayInlineType(EDisplay display)
     {
         return display == INLINE || isDisplayReplacedType(display);
     }
 
+    static bool isDisplayTableType(EDisplay display)
+    {
+        return display == TABLE || display == INLINE_TABLE || display == TABLE_ROW_GROUP
+            || display == TABLE_HEADER_GROUP || display == TABLE_FOOTER_GROUP || display == TABLE_ROW
+            || display == TABLE_COLUMN_GROUP || display == TABLE_COLUMN || display == TABLE_CELL
+            || display == TABLE_CAPTION;

[meade_UTC10, 2016/09/26 03:26:02]

Nit: why not do it the way it was before to save so many comparisons?
return display >= FIRST_TABLE_DISPLAY && display <= LAST_TABLE_DISPLAY
?

[sashab, 2016/09/26 03:28:32]

Good point :) It's because A) Code like this causes so many problems when you
try to add a new one (see StyleRecalcChange) and B) EDisplay is about to become
an enum class, so numerical evaluators don't work (and for good reason!) :)

+    }
+
     // Color accessors are all private to make sure callers use visitedDependentColor instead to access them.
     StyleColor borderLeftColor() const { return m_surround->border.left().color(); }
     StyleColor borderRightColor() const { return m_surround->border.right().color(); }
     StyleColor borderTopColor() const { return m_surround->border.top().color(); }
     StyleColor borderBottomColor() const { return m_surround->border.bottom().color(); }
     StyleColor backgroundColor() const { return m_background->color(); }
     Color color() const;
     StyleColor columnRuleColor() const { return m_rareNonInheritedData->m_multiCol->m_rule.color(); }
     StyleColor outlineColor() const { return m_background->outline().color(); }
     StyleColor textEmphasisColor() const { return m_rareInheritedData->textEmphasisColor(); }
@@ skipping 129 matching lines @@
 }
 
 inline bool ComputedStyle::hasPseudoElementStyle() const
 {
     return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
 }
 
 } // namespace blink
 
 #endif // ComputedStyle_h