Make NGFragment to own NGPhysicalFragment

third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
index b225795d24ae998e14aba5f93b84c2a6bce0519a..8ce9c8c47f52f10e58d86c4a7e3afd03ebba3caf 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
@@ -18,23 +18,18 @@ class CORE_EXPORT NGPhysicalFragment final : public NGPhysicalFragmentBase {
   // This modifies the passed-in children vector.
   NGPhysicalFragment(NGPhysicalSize size,
                      NGPhysicalSize overflow,
-                     HeapVector<Member<const NGPhysicalFragmentBase>>& children,
+                     Vector<const NGPhysicalFragmentBase*>& children,
                      NGMarginStrut margin_strut)
       : NGPhysicalFragmentBase(size, overflow, FragmentBox, margin_strut) {
     children_.swap(children);
   }
 
-  const HeapVector<Member<const NGPhysicalFragmentBase>>& Children() const {
+  const Vector<const NGPhysicalFragmentBase*>& Children() const {
     return children_;

[cbiesinger, 2016/09/26 17:17:55]

I really think you should document in the builder & in the header of this file
that the child fragments need to be kept alive by the caller as this class just
keeps a pointer to them. that's pretty subtle...

   }
 
-  DEFINE_INLINE_TRACE_AFTER_DISPATCH() {
-    visitor->trace(children_);
-    NGPhysicalFragmentBase::traceAfterDispatch(visitor);
-  }
-
  private:
-  HeapVector<Member<const NGPhysicalFragmentBase>> children_;
+  Vector<const NGPhysicalFragmentBase*> children_;
 };
 
 }  // namespace blink