Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h
index ebd5ea9d68c1341a9c0cf775a181771b7abe2c14..fa38fed7e1310f3eeac80b18eb2ccf0b913732e9 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h
@@ -54,20 +54,18 @@ struct NGExclusion {
// The NGPhysicalConstraintSpace contains the underlying data for the
// NGConstraintSpace. It is not meant to be used directly as all members are in
// the physical coordinate space. Instead NGConstraintSpace should be used.
-class CORE_EXPORT NGPhysicalConstraintSpace final
cbiesinger 2016/09/26 17:17:55 Why remove the final?
- : public GarbageCollectedFinalized<NGPhysicalConstraintSpace> {
+class CORE_EXPORT NGPhysicalConstraintSpace {
public:
NGPhysicalConstraintSpace();
NGPhysicalConstraintSpace(NGPhysicalSize);
- NGPhysicalConstraintSpace(const NGPhysicalConstraintSpace&);
+
+ ~NGPhysicalConstraintSpace() = default;
NGPhysicalSize ContainerSize() const { return container_size_; }
void AddExclusion(const NGExclusion, unsigned options = 0);
const Vector<NGExclusion>& Exclusions(unsigned options = 0) const;
- DEFINE_INLINE_TRACE() {}
-
private:
friend class NGConstraintSpace;

Powered by Google App Engine
This is Rietveld 408576698