third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc - Issue 2365083002: Make NGFragment to own NGPhysicalFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h ('K') | « third_party/WebKit/Source/core/layout/ng/ng_layout_input_text.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

index a5904534bad78af743ea79c743b399b18be73c7d..a23b97fc8e418a0c378da8d8208a763df35201c4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

@@ -36,7 +36,7 @@ static inline bool AscendingTopLeftCompare(const NGExclusion& a,

void NGLayoutOpportunityIterator::FilterExclusions() {

filtered_exclusions_.clear();

- for (const auto& item : constraint_space_->PhysicalSpace()->Exclusions())

+ for (const auto& item : constraint_space_->PhysicalSpace().Exclusions())

filtered_exclusions_.append(item);

nonCopyingSort(filtered_exclusions_.begin(), filtered_exclusions_.end(),

AscendingTopLeftCompare);