Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index 524ac679dc2c58bfc2afd789fd7d5f2499738362..b73e45dc1a104517f9aa9a25df6cfbfa81493a49 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -36,7 +36,7 @@ class CORE_EXPORT NGFragmentBuilder final
// Creates the fragment. Can only be called once.
NGPhysicalFragment* ToFragment();
- DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(children_); }
+ DEFINE_INLINE_VIRTUAL_TRACE(){};
private:
NGPhysicalFragmentBase::NGFragmentType type_;
@@ -48,7 +48,7 @@ class CORE_EXPORT NGFragmentBuilder final
NGMarginStrut margin_strut_;
- HeapVector<Member<NGPhysicalFragmentBase>> children_;
+ Vector<NGPhysicalFragmentBase*> children_;
Vector<NGLogicalOffset> offsets_;
};

Powered by Google App Engine
This is Rietveld 408576698