Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGFragmentBuilder_h 5 #ifndef NGFragmentBuilder_h
6 #define NGFragmentBuilder_h 6 #define NGFragmentBuilder_h
7 7
8 #include "core/layout/ng/ng_fragment.h" 8 #include "core/layout/ng/ng_fragment.h"
9 #include "core/layout/ng/ng_units.h" 9 #include "core/layout/ng/ng_units.h"
10 10
(...skipping 18 matching lines...) Expand all
29 // Sets MarginStrut for the resultant fragment. 29 // Sets MarginStrut for the resultant fragment.
30 NGFragmentBuilder& SetMarginStrutBlockStart(const NGMarginStrut& from); 30 NGFragmentBuilder& SetMarginStrutBlockStart(const NGMarginStrut& from);
31 NGFragmentBuilder& SetMarginStrutBlockEnd(const NGMarginStrut& from); 31 NGFragmentBuilder& SetMarginStrutBlockEnd(const NGMarginStrut& from);
32 32
33 // Offsets are not supposed to be set during fragment construction, so we 33 // Offsets are not supposed to be set during fragment construction, so we
34 // do not provide a setter here. 34 // do not provide a setter here.
35 35
36 // Creates the fragment. Can only be called once. 36 // Creates the fragment. Can only be called once.
37 NGPhysicalFragment* ToFragment(); 37 NGPhysicalFragment* ToFragment();
38 38
39 DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(children_); } 39 DEFINE_INLINE_VIRTUAL_TRACE(){};
40 40
41 private: 41 private:
42 NGPhysicalFragmentBase::NGFragmentType type_; 42 NGPhysicalFragmentBase::NGFragmentType type_;
43 NGWritingMode writing_mode_; 43 NGWritingMode writing_mode_;
44 NGDirection direction_; 44 NGDirection direction_;
45 45
46 NGLogicalSize size_; 46 NGLogicalSize size_;
47 NGLogicalSize overflow_; 47 NGLogicalSize overflow_;
48 48
49 NGMarginStrut margin_strut_; 49 NGMarginStrut margin_strut_;
50 50
51 HeapVector<Member<NGPhysicalFragmentBase>> children_; 51 Vector<NGPhysicalFragmentBase*> children_;
52 Vector<NGLogicalOffset> offsets_; 52 Vector<NGLogicalOffset> offsets_;
53 }; 53 };
54 54
55 } // namespace blink 55 } // namespace blink
56 56
57 #endif // NGFragmentBuilder 57 #endif // NGFragmentBuilder
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698